Let's add support for Aegir HTTPS. We'll add a global encryption option, just like on the site form (disabled, enabled, or required).

We should be able to invoke a new pre-verify hook in hosting_services_save_site() that will run our implementation. If the option is set and the server supports it (perform checks just like the site form), set it on the site. The verify task will then enable/require it.

CommentFileSizeAuthor
#4 hosting_services-automatically_enable_https_if_possible_and_desired-2838326-4.patch10.76 KBcolan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

colan created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Active » Postponed

Waiting for #2847435: Duplicated verify task on site save to be resolved.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Postponed » Active

This is much easier now because of Allow access to the well known directory earlier in the process.

I think we can simply set the option when creating the site node, based on what was selected in the settings here.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Assigned: Unassigned » colan
Status: Active » Postponed
FileSize
hosting_services-automatically_enable_https_if_possible_and_desired-2838326-4.patch10.76 KB

This patch is dependent on Move HTTPS availability checking to its own function so it can be used elsewhere so let's wait until that gets in before committing this.

  • colan committed b20a2fc on 7.x-3.x 
    Issue #2838326 by colan: Automatically enable HTTPS on newly created...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Postponed » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ibraaheem’s picture

ibraaheem CreditAttribution: ibraaheem as a volunteer commented

Good day, thanks for all the great work.
The last commit has broken access to this page -> /admin/hosting/saas.
The error message is:
PHP Fatal error: Call to undefined function hosting_https_status_options() in /var/aegir/hostmaster-7.x-3.11.2/sites/server.XYZ.com/modules/contrib/hosting_services/submodules/hosting_saas/hosting_saas.module on line 122, referer: http://server.XYZ.com/admin/reports/event/4.

On the error started when i tried using SaaS to create a site using Curl.
Cannot populate site creation task: The requested URL 'saastest.XYZ.com' does not match the configured domain 'localhost'.

From my observation, it seems you have made the module to require Aegir HTTPS module as the requested function is not found elsewhere.

Please clarify.
This could save other users days of troubleshooting.
Thanks