When using the included Gruntfile.js Browsersync is not detecting any file changes. This can be fixed by changing

'css/{,*/}*.css'

to

'css/**/*.css'

Same for alle other files types.

Apparently this is the official Grunt pattern syntax?

CommentFileSizeAuthor
#4 browsersync_doesnt_detect_file_changes-2838074-3.patch408 bytesZnak
#6 browsersync_doesnt_detect_file_changes-2838074-6.patch2.2 KBZnak
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

johnnny83 created an issue. See original summary.

leahtard’s picture

leahtard CreditAttribution: leahtard at The Jibe commented

Thanks johnnny83!

If you have a patch ready, upload it here and we can get it applied. Otherwise, we will try an get a fix in this week.

Cheers, Leah

johnnny83’s picture

johnnny83 CreditAttribution: johnnny83 commented

Unfortunately I don't know how to make a patch :(

Znak’s picture

Znak CreditAttribution: Znak at Drupal Ukraine Community commented
Status: Active » Needs review
FileSize
browsersync_doesnt_detect_file_changes-2838074-3.patch408 bytes

Hold, I did patch for this module

johnnny83’s picture

johnnny83 CreditAttribution: johnnny83 commented

You forgot the other files types...

Znak’s picture

Znak CreditAttribution: Znak at Drupal Ukraine Community for Drupal Ukraine Community commented
FileSize
browsersync_doesnt_detect_file_changes-2838074-6.patch2.2 KB

Oh, I'm sorry. Here is updated patch

leahtard’s picture

leahtard CreditAttribution: leahtard at The Jibe commented

Thanks for the patch!

Unfortunately, I cannot replicate the issue. BrowserSync works for me using the existing wildcard pattern. Maybe there are other environment factors coming into play here? Having said that, I tested the changes in the patch and the confirmed everything still works for me. I am going to leave this open for a little while longer for further testing.

Cheers, Leah

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

Can you provide the environment you are having issues with?

johnnny83’s picture

johnnny83 CreditAttribution: johnnny83 commented

I'm using Windows 7 with Git Bash, if this is what you mean...

Znak’s picture

Znak CreditAttribution: Znak commented

leahtard, if everything is ok, you commit my patch?

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

Yes johnny that's what I was looking for because this could be environment related that info is valuable, thank you

leahtard’s picture

leahtard CreditAttribution: leahtard at The Jibe commented

I looked into this issue a little more. The syntax we are using, 'css/{,*/}*.css', seems to be interpolated by node-glob (https://github.com/isaacs/node-glob) -- which is suppose to be a part of node (?). When searching, I saw a lot of people experiencing issues within a Windows environment but found no definitive solution. In my testing, the patch has no negative effect in my Mac environment so I am going to apply it. If anyone experiences any issues, please let us know.

Cheers, Leah

leahtard’s picture

leahtard CreditAttribution: leahtard at The Jibe commented
Version: 8.x-1.2 » 8.x-1.x-dev

  • Znak authored e586b6e on 8.x-1.x 
    Issue #2838074 by Znak, johnnny83, leahtard, joelpittet: Browsersync...
leahtard’s picture

leahtard CreditAttribution: leahtard at The Jibe commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.