Hi,

This commit from issue #2063113: no active trail for menu item/link with token is creating some notice errors:

Notice: Undefined offset: 1 in _menu_translate() (line 787 of includes/menu.inc).

Included, the patch to fix them.

CommentFileSizeAuthor
#4 2838033.patch432 bytesPol
#3 2838033.patch592 bytesPol
#2 2838033.patch602 bytesPol
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pol created an issue. See original summary.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol at European Commission and European Union Institutions, Agencies and Bodies for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review
FileSize
2838033.patch602 bytes

Here's the patch for 7.x-1.x.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol at European Commission and European Union Institutions, Agencies and Bodies for European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
2838033.patch592 bytes

Hi,

After checking deeper, it looks like the following patch has more sense.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol at European Commission and European Union Institutions, Agencies and Bodies for European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
2838033.patch432 bytes

The previous patch includes unwanted code that I forgot to remove while doing my tests.

Here's a final version of the patch.

4kant’s picture

4kant CreditAttribution: 4kant commented

Thanks Pol,
#4 helped me.

Merry christmas!

NWOM’s picture

NWOM CreditAttribution: NWOM commented
Status: Needs review » Reviewed & tested by the community

#4 worked great. Thank you.

DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy at Dilygent commented

Are you sure Menu Token keeps working the same with this patch? The menu item created by this module is absolutely critical, if it is not set right, everything will break!!

Please RTBC only if you have tested all functionality.

Thanks!

NWOM’s picture

NWOM CreditAttribution: NWOM commented

@develCuy, It is in use and working with this patch successfully. I wouldn't have RTBCed it otherwise. All functionality seems to be intact thus far.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol at European Commission and European Union Institutions, Agencies and Bodies for European Commission and European Union Institutions, Agencies and Bodies commented

Yes the module works with the latest patch of this thread.

MaskOta’s picture

MaskOta CreditAttribution: MaskOta commented

Patche worked for me aswell. Thanks

  • develCuy committed 1598e7b on 7.x-1.x authored by Pol 
    Issue #2838033 by Pol, NWOM: Notice errors after commit of this patch in...
DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy at Dilygent commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch @Pol!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.