Update Help message

1. +++ b/content_report.module
   @@ -15,7 +15,12 @@ function content_report_help($path, $arg) {
   +        $output .= "<li>" . t("If you have Drush installed, use ") . "<code>drush ldl jquery.tablesorter

";


Translatable strings shouldn't begin or end with white spaces, use placeholders with t() for variables.

Do not concatenate strings to translatable strings, they should be part of the t() argument.

2. +++ b/content_report.module
   @@ -15,7 +15,12 @@ function content_report_help($path, $arg) {
   +        $output .= "<li>" . t("If you don't have Drush installed, you can download library from git repo: <a href='@libgitrepo'>https://github.com/christianbach/tablesorter</a>", array('@libgitrepo' => 'https://github.com/christianbach/tablesorter')) . "</li>";
   

   Do not concatenate strings to translatable strings, they should be part of the t() argument.

@bhavikshah9, if you care to reroll your patch with @emcoward's suggestions I'd be happy to give you commit credit for it. Otherwise I can implement the changes.

Thanks to both of you for your review.

@emcoward, are these the changes you mean? Please review the patch.

Update Patch #6

Help Message changed. Attached OLD & NEW screenshots.

I've reviewed the patch in #7 (2837922-7.patch).

It's looking good apart from a couple of tiny points:

• There should be a space between the opening PHP tag.
• Line 24 'return $output' should be indented 6 rather than 4.

The issue 'Do not concatenate strings to translatable strings, they should be part of the t() argument' could be fixed by doing something like:

$output .= "<li>";
$output .= t("If you don't have Drush installed, you can download library from git repo: <a href='@libgitrepo'>@libgitrepo</a>", array('@libgitrepo' => 'https://github.com/christianbach/tablesorter'));
$output .= "</li>";
$output .= "</ol>";

Also makes it slightly easier to read/follow.

As suggested in #10 . I have made the changes . Please review.

@bhavikshah9 looks good. Just need to add a space after the opening PHP tag and the comment and it's good to go.

Hello,

I added the space after php open tag and passed the drupal code sniffer in the module.

Hi.

It's good for me.

Congrats.

Grt

Latest patch looks good! Good to go.

I'd suggest using theme('item_list', ...) to add the list rather than concatenating each line of HTML manually.

This looks good . Working as expected .

Cheers
SwapS