This patch will add the ability to select a type of animation for the message.

CommentFileSizeAuthor
#5 2837860-option-animation-type.patch2.46 KBKen Patolia
#2 2837860-dismiss_slideup-2.patch807 bytesbwaindwain

Issue fork dismiss-2837860

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bwaindwain created an issue. See original summary.

bwaindwain’s picture

bwaindwain commented
Status: Active » Needs review
StatusFileSize
new 2837860-dismiss_slideup-2.patch807 bytes
rupl’s picture

rupl
he/him
Primary language English
commented
Title: use slideup animation » Offer options for different animations
Status: Needs review » Needs work

Thanks for the patch! I'm actually not a fan of slideUp because it causes several reflows and repaints as it changes the CSS height of the element. There's also a difference between the two blocks of code. One is for user interaction and one is for an automatic timeout as defined in the Drupal admin settings for the module.

Given that this is often a publicly visible component of a site I also don't want to switch the default behavior. If you'd like, rework the patch to include a new setting that allows the administrator to select which affect should be used to dismiss the message. Then we can keep the original settings as default and still offer other options when someone has a different preference.

KENPATOLIA made their first commit to this issue’s fork.

Ken Patolia’s picture

Ken Patolia commented
Issue summary: View changes
Parent issue: » #2837860: Offer options for different animations
StatusFileSize
new 2837860-option-animation-type.patch2.46 KB

As per your request, I have added an option in the form to select the type of animation, and based on that it will add effect in animation to the message.

Please check and approve my patch.

I also want to help you with Drupal 8 and Drupal 9 porting of this module so please add me as co-maintainer so can push my code.

Thanks,
Ken Patolia

Ken Patolia’s picture

Ken Patolia commented
Status: Needs work » Needs review
astonvictor’s picture

astonvictor commented
Status: Needs review » Closed (outdated)

D7 reached its EOL back in January 2025, and there is no active release for D7 for this module anymore.
Development or support is not planned for D7. All D7-related issues are marked as outdated in a bunch.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.