At this moment we use the raw value in the url.

We should make this pluggable so, on a per-facet base, we can swap this into a custom Coder to support e.g. slugified taxonomy terms, or pathauto based taxonomy terms

CommentFileSizeAuthor
#11 create_a_pluggable-2837835-11.patch16.02 KBborisson_
#11 interdiff.txt5.27 KBborisson_
#10 create_a_pluggable-2837835-10.patch15.34 KBStryKaizer
#7 create_a_pluggable-2837835-7.patch15.3 KBStryKaizer
#6 create_a_pluggable-2837835-6.patch13.87 KBStryKaizer
#3 create_a_pluggable-2837835-3.patch7.17 KBStryKaizer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

StryKaizer created an issue. See original summary.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Issue summary: View changes
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Active » Needs work
FileSize
create_a_pluggable-2837835-3.patch7.17 KB

Initial start, discoverable plugin system created and a non-working configuration form on a per-facet base (only visible when pretty paths is configured for the given facet source).

Still todo

- interface might still change, non-working now
- use actual plugin implementation
- selected coder still needs to be stored on the facets_facet entity config object

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Issue summary: View changes
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Issue summary: View changes
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
FileSize
create_a_pluggable-2837835-6.patch13.87 KB

Working (temporary) Coder plugin which prepends the raw value with "banana-" now available, next to the default (raw value) coder.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Needs work » Needs review
FileSize
create_a_pluggable-2837835-7.patch15.3 KB

Taxonomy coder from #2836122: Port D7 taxonomy coder now ported to use coder plugin system.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented

StryKaizer credited ckng.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
FileSize
create_a_pluggable-2837835-10.patch15.34 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
FileSize
interdiff.txt5.27 KB
create_a_pluggable-2837835-11.patch16.02 KB 
+++ b/src/Coder/CoderPluginBase.php
@@ -0,0 +1,23 @@
+  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
+    /** @var \Symfony\Component\HttpFoundation\Request $request */
+    $request = $container->get('request_stack')->getMasterRequest();
+    return new static($configuration, $plugin_id, $plugin_definition, $request);
+  }

Why do we need this? I think this can go. Actually, I think the entire base class can go.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented

You are absolutely right, thanks!

  • StryKaizer committed a697645 on 8.x-1.x 
    Issue #2837835 by StryKaizer, borisson_: Create a pluggable system for...
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Needs review » Fixed
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Issue tags: +dcnlights

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.