Problem/Motivation

It looks like the unit for the player dimensions is not stored as config for the BrightcovePlayer entity.

This causes dimensions set as % on the Brightcove admin to be rendered as px on the Drupal site.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
brightcove-player-dimensions.jpg301.64 KBshadcn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arshadcn created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented

One way to deal with that would be another flag on the entity defining that they are relative.

  • 4f26d99 committed on 8.x-2.x 
    Removed assignments in `if` for player related changes DO#2837795
  • 5d2b275 committed on 8.x-2.x
    Fix comment DO#2837795
  • caa5925 committed on 8.x-2.x
    Merged in drupalorg/ticket/2837795 (pull request #1)

Update player...
  • df1bdec committed on 8.x-2.x
    Update player related implementation DO#2837795

Depricated players with...
yce’s picture

yce CreditAttribution: yce at Pronovix for BrightCove commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Active » Fixed

@dawehner I've added the units for the players, it was not really trivial because of the different settings of the player, it should be ok now.

I've also deprecated the 5.x version of the players, so only the new players will be displayed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.