Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
While translating Drupal core during a translation sprint I found out that the help texts in responsive_image_help()
incorrectly include the closing tag for the definition data elements. The t() call should end before these closing tags.
NB: bug has no visible effect, but to check affected page:
- enable 'Responsive Image' core module
- rebuild cache
- browse to /admin/help/responsive_image
Proposed resolution
Move closing tags outside t() call, to match opening.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#2 | incorrect_closing_of-2837072-2.patch | 6.35 KB | BarisW |
Comments
Comment #2
BarisW CreditAttribution: BarisW as a volunteer and at LimoenGroen commentedComment #3
wturrell CreditAttribution: wturrell as a volunteer commentedLooks good to me.
No regressions, code style issues, in scope, no tests needed.
Comment #4
alexpottNice find - I'm committing this to 8.2.x as well because although it is a string change it is a bug.
Committed and pushed 8a0ad8f to 8.3.x and 412b615 to 8.2.x. Thanks!