Problem/Motivation

While translating Drupal core during a translation sprint I found out that the help texts in responsive_image_help() incorrectly include the closing tag for the definition data elements. The t() call should end before these closing tags.

NB: bug has no visible effect, but to check affected page:

  1. enable 'Responsive Image' core module
  2. rebuild cache
  3. browse to /admin/help/responsive_image

Proposed resolution

Move closing tags outside t() call, to match opening.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

BarisW created an issue. See original summary.

BarisW’s picture

Status: Active » Needs review
FileSize
6.35 KB
wturrell’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good to me.
No regressions, code style issues, in scope, no tests needed.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +String change in 8.3.0, +String change in 8.2.6

Nice find - I'm committing this to 8.2.x as well because although it is a string change it is a bug.

Committed and pushed 8a0ad8f to 8.3.x and 412b615 to 8.2.x. Thanks!

  • alexpott committed 8a0ad8f on 8.3.x
    Issue #2837072 by BarisW: Incorrect closing of the t() call in the help...

  • alexpott committed 412b615 on 8.2.x
    Issue #2837072 by BarisW: Incorrect closing of the t() call in the help...

  • alexpott committed 8a0ad8f on 8.4.x
    Issue #2837072 by BarisW: Incorrect closing of the t() call in the help...

  • alexpott committed 8a0ad8f on 8.4.x
    Issue #2837072 by BarisW: Incorrect closing of the t() call in the help...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.