Hello,

I randomly found that anonymous users can access the feed list page /admin/content/feed because the view does not provide access check.

I think to also change the permission for the page in routing.yml to use the access feed overview page.

I will upload a patch.

CommentFileSizeAuthor
#2 feeds-anonymous_access-2836998-2.patch1.3 KBGrimreaper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Grimreaper created an issue. See original summary.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Assigned: Grimreaper » Unassigned
Status: Active » Needs review
FileSize
feeds-anonymous_access-2836998-2.patch1.3 KB

Here is the patch.

After checking how works admin/content, I have only modified the view config.

Does this need a hook_update?

daboo’s picture

daboo CreditAttribution: daboo commented

This is controllable via permissions under Feeds -> Access the Feed overview page". I merely changed it to Administrator to keep others from accessing.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented

Hello @daboo,

The problem is that this permission is not used by the view provided by default.

And as the view responds on the same URL a default route in feeds.routing.yml has, even if the route requires this permission, anonymous users can access the listing.

daboo’s picture

daboo CreditAttribution: daboo commented

Thanks for the update @Grimreaper. I wasn't aware of that.

  • MegaChriz committed 129e53d on 8.x-3.x authored by Grimreaper 
    Issue #2836998 by Grimreaper: Fixed anonymous can access feeds listing (...
MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Priority: Normal » Critical
Status: Needs review » Fixed

Great catch! Seems pretty critical too. I can confirm that the patch fixes the issue if I re-import the configuration file.

I think there is no need for a hook_update now, as there is no official release of Feeds 8.x-3.x yet, only a dev release.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented

OK.

Thanks for the commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.