Tax was not updating while changing address zone [#2836411]

Problem

I have created a tax in Ubercart tax with condition based on my State/Province value. This tax value will update in total only when the country or postal code value changes, not State/Province value. This is because _uc_ajax_defaults only set for country and postal code fields.

Preferred Solution

The attached patch file will apply the tax while changing the State/Province value. In this patch file, I have added State/Province field to the _uc_ajax_defaults function.

Comment	File	Size	Author
	default-zone-ajax.patch	757 bytes	siva_drupal
	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 125 pass PHP 5.4 & MySQL 5.5, D7 125 pass PHP 5.5 & MySQL 5.5, D7 125 pass PHP 5.6 & MySQL 5.5, D7 125 pass PHP 7 & MySQL 5.5, D7 125 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

16 December 2016 at 15:29

siva_drupal created an issue. See original summary.

Comment #2

TR CreditAttribution: TR commented 16 December 2016 at 19:34

Category:

Task

» Support request

Did you try uc_ajax_admin? /admin/store/settings/checkout/ajax

Comment #3

siva_drupal CreditAttribution: siva_drupal as a volunteer and commented 17 December 2016 at 06:50

Hi TR,

Sometimes uc_ajax_admin load for a long time. For that reason only I created this patch for add State/Province field ajax call back without using the uc_ajax_admin module.

Comment #4

siva_drupal CreditAttribution: siva_drupal as a volunteer and commented 17 December 2016 at 12:40

Status:

Active

» Needs review

Comment #5

17 December 2016 at 19:50

Status:

Needs review

» Needs work

The last submitted patch, default-zone-ajax.patch, failed testing.

Comment #6

TR CreditAttribution: TR commented 30 December 2016 at 08:30

Version:	7.x-3.9	» 7.x-3.x-dev
Status:	Needs work	» Needs review

1) Patches need to be made against HEAD, which in this case is 7.x-3.x
2) The testbot seems to have failed for your patch, so I'm setting this to "Needs review" again to prompt the testbot to look at it again.
3) I'm not in favor of this change. uc_ajax_admin was designed specifically so that site builders could choose whatever fields they wanted as trigger elements. We can't possibly support every choice or combination of choices out of the box, but we can and we have provided you with a mechanism to choose your own triggers.
4) If you think uc_ajax_admin has problems, then THAT is what needs to be fixed. Changing the trigger elements just for your site doesn't solve anything.

Comment #7

siva_drupal CreditAttribution: siva_drupal as a volunteer and commented 30 December 2016 at 09:47

Thanks TR, Just now I realize the problem. It's not in uc_ajax_admin, problem exists in calculating fedex shipping service charges.

In the checkout page, I initialize fedex shipping services. This fedex calculation slow down my ajax process in checkout. Do you have any idea to speed up those things?