Problem/Motivation

The Rate results tab is intended to appear for node entities, on the node canonical tabs when a node bundle is enabled for voting.

However, if there is more than 1 node bundle enabled for voting, or if there is also a non-node entity enabled for voting, the Rate results tab disappears. Currently it unsets the tab if there are any bundles enabled that is not the current node bundle.

Proposed resolution

Tweak the logic in the rate_menu_local_tasks_alter() function, to check if the entity type is a node, and if the current node bundle is voting enabled. Otherwise, unset the tab.

Remaining tasks

Patch needs review.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 rate-results-tab-disappears-fix-2836201-2.patch944 bytesmroycroft
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mroycroft created an issue. See original summary.

mroycroft’s picture

mroycroft CreditAttribution: mroycroft commented
FileSize
rate-results-tab-disappears-fix-2836201-2.patch944 bytes

Here is the proposed fix.

mroycroft’s picture

mroycroft CreditAttribution: mroycroft commented
Issue summary: View changes
Status: Active » Needs review
dangelo5’s picture

dangelo5 CreditAttribution: dangelo5 commented

Verified this fix.
Results tab displays for content types that are configured for voting.

dangelo5’s picture

dangelo5 CreditAttribution: dangelo5 commented
Status: Needs review » Reviewed & tested by the community
brenk28’s picture

brenk28 CreditAttribution: brenk28 at Phase2 for Workday, Inc. commented
Assigned: Unassigned » brenk28

  • brenk28 committed bc6c92f on 8.x-1.x 
    Issue #2836201 by mroycroft, dangelo5: Fix rate results tab disappearing...
brenk28’s picture

brenk28 CreditAttribution: brenk28 at Phase2 for Workday, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.