Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In the 7.x branch there was a variable "disable_captcha" that could be included in settings.php
Can this be re-introduced in the 8.x branch?
Comment | File | Size | Author |
---|---|---|---|
#19 | interdiff_13-19.txt | 485 bytes | Neslee Canil Pinto |
#19 | 2836076-19.patch | 1.52 KB | Neslee Canil Pinto |
| |||
#13 | 2836076-bypass-in-settings.patch | 1.5 KB | dotist |
| |||
#7 | captcha--disable_captcha_variable--added_test--2836076-07.patch | 3.41 KB | smaz |
#6 | captcha--disable_captcha_variable--added_test--2836076-06.patch | 3.41 KB | alunyov |
Comments
Comment #2
ndf CreditAttribution: ndf at Dx Experts for Triquanta commentedThis patch contains:
- Calls variable 'disable_captcha' in function captcha_validate()
- Documentation in README.md
Did not add the variable in captcha.install, because don't want this variable exported with Configuration Management.
It should only be an (optional) override in settings.php
Comment #3
ndf CreditAttribution: ndf at Dx Experts for Triquanta commentedComment #4
naveenvalechaCould you add a test for this.
Comment #5
dmsmidtSeems as a nice feature request.
I'll manually test after we have a unit test (which imho is not a novice task).
Comment #6
alunyov CreditAttribution: alunyov at FFW commentedHi Guys,
I have updated the patch:
1. I added test for testing the form with switched off captcha validation.
2. I have updated condition for switching off validation to:
Comment #7
smazI've tested & reviewed the patch, and it works great - thanks!
I have made one very minor edit:
The comment in the new test was:
This is incorrect - the log in should pass. I think that was just left from a copy / paste of the existing test. I've attached a new patch which just changes the comment to say pass.
Because I've only changed a word in the comment, I've marked as RTBC.
Cheers
Comment #11
couturier CreditAttribution: couturier as a volunteer commentedObviously work isn't proceeding very quickly as far as upgrading to a stable 8.x version, and we'd love to see this and other features added. Is anyone able to jump in and help give this module's progress a boost? See the discussion at attached link.
Comment #12
PieterDCI currently work around not having a 'disable_captcha' setting by uninstalling the CAPTCHA module in the test its setUp() method after it installed the profile which installed CAPTCHA.
Comment #13
dotist CreditAttribution: dotist at LOOM GmbH commentedI've re-rolled the patch with some minor changes.
Comment #14
wundo CreditAttribution: wundo at Chuva Inc. commentedRunning tests
Comment #15
wundo CreditAttribution: wundo at Chuva Inc. commentedComment #16
wundo CreditAttribution: wundo at Chuva Inc. commentedThe patch is not following the code standards.
Comment #17
margyly CreditAttribution: margyly commentedThis would allow us to put this in an environment-specific settings.php, right? So CAPTCHA could be disabled on a dev or staging site?
Comment #18
margyly CreditAttribution: margyly commentedIt would also be cool if we could use `drush cset` to enable and disable it, for use in automated testing.
Comment #19
Neslee Canil PintoComment #20
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedPatch from #19 applies without any issues and looks good, also coding standard issus are fixed.
Comment #21
nevergone CreditAttribution: nevergone commentedComment #22
nevergone CreditAttribution: nevergone commentedTested and works well!
Comment #23
pcambraConfirming RTBC!
Comment #25
japerryTested great. Committed.