It looks like the html.tpl.php template has a hardcoded path to https://cdn.jsdelivr.net/html5shiv/3.7.3/html5shiv-printshiv.min.js, but the settings looks like you may decided against using jsdelivr.

This can be done dynamically and required no hardcoding:

/**
 * Implements hook_process_HOOK().
 */
function bootstrap_process_html(&$variables) {
  $theme_path = drupal_get_path('theme', 'bootstrap');

  // @todo: Append html5shim until http://drupal.org/node/865536 is fixed.
  $default_query_string = variable_get('css_js_query_string', '0');
  $variables['scripts'] .= '<!--[if lt IE 9]>' . "\n";
  $variables['scripts'] .= '<script src="' . file_create_url($theme_path . '/js/html5shiv-printshiv.js') . '?' . $default_query_string . '"></script>' . "\n";
  $variables['scripts'] .= '<![endif]-->' . "\n";
}

Comments

hass created an issue. See original summary.

hass’s picture

hass CreditAttribution: hass commented
Issue summary: View changes
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Active » Closed (won't fix)

but the settings looks like you may decided against using jsdelivr

The "CDN" theme setting is only for the Bootstrap Framework itself, not this shiv.

This was only changed to utilize jsDelivr because of #2724195: Bootstrap relies on Googlecode for HTML5Shiv, which no longer exists.

Also, it's not "hardcoded". One can easily override html.tpl.php in a sub-theme if it's truly not needed or a different implementation (such as your example above) is desired/needed.

Furthermore, this project has never bundled any 3rd party libraries/resources, nor is it going to start doing so.

hass’s picture

hass CreditAttribution: hass commented
Status: Closed (won't fix) » Active

Making this a setting like all other URL settings would be useful. This URL is hidden from the UI and this is unexpected if I disable all CDN and there is still one active that is pointing to an URL that may go down in future.

Simply wait until a patch has been shared. There is no need for bundeling, this can also be a setting to a CDN or my local folders.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Active » Closed (won't fix)

Feature requests, unless it's a simple addition (like with the sass starterkit recently), will likely not get added to 7.x-3.x.

8.x-3.x is now HEAD (as indicated in git), I would have moved this to the 8.x-3.x branch, but we're using the shiv supplied with core in 8.x.

---

Considering that any change to a template is technically a BC break, this is also a non-starter because adding it in a preprocess would double the implementation until the sub-theme's overridden html.tpl.php template was altered for this change.

As I stated above, if you want/need this change, you can do so in a sub-theme.

---

Not everything is, or should be, a UI setting.