In DvG 1.0 a label is added on searchresults in multi-domain websites, to inform the user when a search result is opening in an other (sub)domain or is an external link "(opens website [website name])". This message is now also shown on the searchpage for single-domein DvG sites, which is unnecessary.

CommentFileSizeAuthor
#6 dvg-search-without-domains-2835115-6.patch1.96 KBTVoesenek
#5 dvg-search-without-domains-2835115-5.patch1.94 KBruudvanoijen
#4 dvg-search-without-domains-2835115-4.patch2.17 KBruudvanoijen
#3 dvg-search-without-domains-2835115-3.patch2.17 KBruudvanoijen
#2 dvg-search-without-domains-2835115-2.patch1.54 KBpaulvandenburg
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Tom Voesenek created an issue. See original summary.

paulvandenburg’s picture

paulvandenburg CreditAttribution: paulvandenburg at ezCompany commented
FileSize
dvg-search-without-domains-2835115-2.patch1.54 KB

Made a fix for this issue. It seems like external links never got the "opens external website" notice when domains was disabled. This seemed like unintended behavior and is also fixed with this patch. Due to this extra fix it needs further review and testing which my colleagues will pick up.

ruudvanoijen’s picture

ruudvanoijen CreditAttribution: ruudvanoijen at ezCompany commented
Version: 7.x-1.0 » 7.x-1.x-dev
Assigned: Unassigned » ruudvanoijen
Status: Active » Needs review
FileSize
dvg-search-without-domains-2835115-3.patch2.17 KB

Made a better patch.

This one was tested using domains and no domains.

With domains
Current domain gets no text.
Internal domain get text from which domain
External gets external text.

ruudvanoijen’s picture

ruudvanoijen CreditAttribution: ruudvanoijen at ezCompany commented
FileSize
dvg-search-without-domains-2835115-4.patch2.17 KB

One thing i missed.

ruudvanoijen’s picture

ruudvanoijen CreditAttribution: ruudvanoijen at ezCompany commented
FileSize
dvg-search-without-domains-2835115-5.patch1.94 KB

Better patch. Seems the no domains still was giving an error.

TVoesenek’s picture

TVoesenek CreditAttribution: TVoesenek commented
FileSize
dvg-search-without-domains-2835115-6.patch1.96 KB

Patch works, but I've added a small modification to @ruudvanooijen's patch to make the domains-check better.

mvwensen’s picture

mvwensen CreditAttribution: mvwensen commented
Status: Needs review » Reviewed & tested by the community

Patch applies and seems to work correct on my test site.

BarisW’s picture

BarisW CreditAttribution: BarisW at LimoenGroen for Historisch Centrum Overijssel commented

Can we have this committed please?

ralphvdhoudt’s picture

ralphvdhoudt CreditAttribution: ralphvdhoudt at ezCompany commented
Status: Reviewed & tested by the community » Fixed

Commited

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.