\Drupal\sms\EventSubscriber\SmsMessageProcessor::chunkMaxRecipients is chunking incoming messages.

chunkMaxRecipients should only work for outgoing messages.

Needs test coverage.

CommentFileSizeAuthor
#5 fix-incoming-chunking-2834908-5.patch5.51 KBdpi
#2 fix-incoming-chunking-2834908.patch3.36 KBdpi
#2 fix-incoming-chunking-2834908-testonly.patch2.06 KBdpi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Active » Needs review
FileSize
fix-incoming-chunking-2834908-testonly.patch2.06 KB
fix-incoming-chunking-2834908.patch3.36 KB

https://github.com/dpi/smsframework/pull/64

The last submitted patch, 2: fix-incoming-chunking-2834908-testonly.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Issue tags: +release-8.x-1.0-beta2

added release-8.x-1.0-beta2 tag.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
FileSize
fix-incoming-chunking-2834908-5.patch5.51 KB

Added some incoming message object helpers to test trait.

  • dpi committed 798ac4b on 8.x-1.x 
    Issue #2834908 by dpi: Prevent chunkMaxRecipients from chunking incoming...
dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Needs review » Fixed

Merged this now since it has some incoming message utilities that are useful for the other active incoming issues:

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.