Add tests for per-type access checking

Advanced access is challenging.

If a user has view permission on a paragraph but not edit, we can easily indicate each unediable paragraph just with the collapsed summary.
If a user wouldn't even be allowed to view a paragraph, then we have a problem.

For advanced content building, those things are very important.
We can place functional paragraphs (such as a view) and lock them down. The editor can then only edit the regular content fields.
This case needs more investigation combined with library, templates, and other cases.
In some projects, we had limitations about strict positioning. Thus, we would need not only lock editing of the paragraphs, but also make it non-drag-and-drop'able. It's hard to design something that works clean and easily with these requirements.

Mind that we have our Paragraphs Access plugin as a starting point.
We will need this to limit error in our future installation. Might need multiple dedicated issues.

Yeah, but things like preventing drag & drop is pretty advanced and IMHO new features. If I'm correct then this is a bug and a pretty serious one.

1. +++ b/modules/paragraphs_type_permissions/src/Tests/ParagraphsTypePermissionsTest.php
   @@ -170,6 +170,15 @@ class ParagraphsTypePermissionsTest extends WebTestBase {
   +    //Check the authenticated user with edit permission.
   

   Missing space between "//" and "Check".

2. +++ b/src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php
   @@ -629,6 +629,9 @@ class InlineParagraphsWidget extends WidgetBase {
   +      // Access for the top element is set to FALSE only when the paragraphs
   +      // was removed.
   +      // A paragraphs that user can not edit has access on lover level.
   

   Let's use Paragraph instead of Paragraphs, otherwise "Paragraphs was" doesn't really make sense. Also don't create a new line after "." Continue the comment in the same line.

1. +++ b/modules/paragraphs_type_permissions/src/Tests/ParagraphsTypePermissionsTest.php
   @@ -170,6 +170,15 @@ class ParagraphsTypePermissionsTest extends WebTestBase {
   +    $this->drupalGet('node/' . $node->id() . '/edit');
   +    $this->assertRaw('Image + Text');
   +    $this->assertText('You are not allowed to edit or remove this Paragraph.');
   

   We can do a bit better I think.

   We should make sure that we can see the content of the image + text field, and that we can see the add button for image + text but not the one for the other type we don't have access to.

2. +++ b/src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php
   @@ -629,6 +629,8 @@ class InlineParagraphsWidget extends WidgetBase {
   +      // removed. A paragraphs that user can not edit has access on lover level.
   

   that *a* user

   lover level? what is that exactly? ;)

   also, this is supposed to comment the part where we decrement real item count

Isn't this accomplished by the sub module "paragraphs type permissions"?

Yes, we are just adding explizit tests and better because the current logic is very non-intuitive.

The tests don't correspond to the issue summary.

Are we now trying to improve / overhaul the real item count or other internal counters?
We didn't add any access denied state.
And i guess we need a paragraph field with count limitation and make sure a user without access to one of the paragraphs is able to add one more.
And Berdir said that saving a host entity without access to a paragraph results in deletion of the items.
Lots of things to check and cover. :-)

I tested this with @Berdir and we deal that everything is working nice, and we only need test coverage.

deal => confirmed ;)

But yes, issue summary needs to be updated.

And we have some better tests of the access thingy! Committed! :-)