I find the StripeApiService::call method quite handy because of the built-in logging. However I would like to be able to also catch execeptions on my code so I can act accordingly insetad of just relying on null checking which provide very little information.

CommentFileSizeAuthor
#5 allow_for_stripe-2834605-5.patch2.24 KBsean_e_dietrich
#4 allow_for_stripe-2834605-4.patch2.23 KBsean_e_dietrich
#3 allow_for_stripe_d7-2834605-3.patch727 byteswelly
#2 allow_for_stripe-2834605-2.patch2.38 KBesclapes
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

esclapes created an issue. See original summary.

esclapes’s picture

esclapes CreditAttribution: esclapes as a volunteer commented
Status: Active » Needs review
FileSize
allow_for_stripe-2834605-2.patch2.38 KB

Here is a patch that uses a second method with an extra parameter for whether on not to re-throw. I did not want to change the signature of the call method, so I moved the logic to the new one.

welly’s picture

welly CreditAttribution: welly at Fat Beehive commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
FileSize
allow_for_stripe_d7-2834605-3.patch727 bytes

Thanks for this, I've created a D7 backport of your patch which works very well.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
CreditAttribution: sean_e_dietrich as a volunteer commented
FileSize
allow_for_stripe-2834605-4.patch2.23 KB

Patch #2 cannot be applied to the recent dev version and fails when being applied. Rerolled the patch to work with the latest version of the dev branch.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
CreditAttribution: sean_e_dietrich as a volunteer commented
FileSize
allow_for_stripe-2834605-5.patch2.24 KB

I actually realized that now after uploading the previous patch it was incorrect as it called the wrong variable names. Modified patch to use the correct variables.