Apparently beta means something different in the Drupal console camp because it certainly does not mean that people should be integrating with it b/c they have drastically changed the API and we need to rework the command.

* Currently it no longer registers as a command.
* There also appears to be several classes that are no longer available that we are using.

Last known version of drupal console that the command worked with beta2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grndlvl created an issue. See original summary.

grndlvl’s picture

Issue summary: View changes
grndlvl’s picture

First pass.

@todo:

  1. Error from Filesystem::mkdir
    [Symfony\Component\Filesystem\Exception\IOException]
    Failed to create "/home/jonathan/Projects/test/ckeditor_media_embed/web/libraries/ckeditor/plugins/autoembed": The ability to pass file names to the Symfony\Component\Yaml
    \Yaml::parse method is deprecated since version 2.2 and will be removed in 3.0. Pass the YAML contents of the file instead..
  2. The translated strings are not showing up correctly.
grndlvl’s picture

This is because errors are being suppressed somewhere and Filesystem::mkdir() is using error_get_last() to check if it should re-throw one of their own suppressed errors... this will be fun...

jlamp’s picture

Working from #4, the only errors I got from trying to run the Install command were from the using statements being outdated. Just added /Core/ in the Drupal Console using statements for Command and Styles, and #4 (with uncommenting the code that actually downloads the files) worked great.

Patch Submitted.

jlamp’s picture

Status: Needs work » Needs review
grndlvl’s picture

This is looking great. The only part that doesn't seem to be working now is that the messages are not displaying correctly only their ids are showing.

i.e.

commands.ckeditor_media_embed.install.messages.comment-downloading-package

Should say "'Downloading CKEditor package version %s...'" where "%s is the version name

These use to translate via Drupal console by placing the text in console/translations/en/ckeditor_media_embed.install.yml and calling $this->trans('commands.ckeditor_media_embed.install.messages.comment-downloading-package'); in code.

grndlvl’s picture

Status: Needs review » Needs work
jlamp’s picture

Patch Submitted.

The class needed an annotation for it to work. Added the Annotation using statement (and also sorted using statements alphabetically so it's easier to read) and added in the annotation, now the strings are being translated correctly.

  • jlamp authored e2d493b on 8.x-1.x
    Issue #2834317 by jlamp, grndlvl: Get InstallCommand back working with...
grndlvl’s picture

Status: Needs review » Fixed

Awesome sauce, committed! Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.