Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Currently menu appears above the toggle button. I am not sure why we have this toggle button appearing below menu.
D8 bartik theme menu toggle button appears above menu so I feel it should be consistent.
Check #106 later comments for D8 discussion.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | Menu_toggle_button_position_change-2834218-2.patch | 1.71 KB | abarpetia |
Comments
Comment #2
abarpetia CreditAttribution: abarpetia as a volunteer commentedAttached patch has been committed.
Comment #5
System Lord CreditAttribution: System Lord commentedThis patch does present menu toggle much better, however, where I have Fiverstar(.js) loaded to a page it breaks the menu toggle (or this patch breaks itself). Meaning: After this patch install (or using Dev version of module), menu toggle does not stay open. When I click on it it opens and closes immediately.
My uneducated conclusion is that this issue has something to do with this patch and this: https://www.drupal.org/project/responsive_bartik/issues/2955412#comment-...
Any ideas?
Comment #6
abarpetia CreditAttribution: abarpetia as a volunteer commentedHello System Lord, Actually this patch is just moving menu to display below toggle button. It's not adding any new functional change to module.
It's just a javascript file loading/execution order, Module dev branch loading menu-toggle button first and then Fiverstar(.js) overriding it. In 7.x-1.0 version, Fiverstar(.js) file is loading first then menu-toggle button. That's why Fiverstar(.js) file could not able to find this link and not override it.