Problem/Motivation

Following notice is thrown in PublishContentNode::render():

Notice: Only variables should be passed by reference in Drupal\Publishcontent\Plugin\Views\field\PublishContentNode->render() (line 56 of publishcontent/src/Plugin/views/field/PublishContentNode.php).

Proposed resolution

Store the render array first in a variable before passing it to the other render function.

Remaining tasks

Reviews needed.

User interface changes

None

API changes

None

CommentFileSizeAuthor
publishcontent-only-variable-by-reference.patch626 bytesdas-peter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

das-peter created an issue. See original summary.

grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl as a volunteer commented

Patch works fine, consider changing the variable name to a single word or camel-case.

Sut3kh’s picture

Sut3kh CreditAttribution: Sut3kh as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Patch works.

Maintainer does seem to prefer camel case vars but as there are none in the file I believe it is fine as per Drupal CS and not worth dragging out this 1 liner patch any longer IMO.

jeremyr’s picture

jeremyr CreditAttribution: jeremyr commented

Also confirming that the patch worked.

arunkumark’s picture

arunkumark
Location Coimbatore
CreditAttribution: arunkumark as a volunteer and at DrupalPartners for CodeExpertz commented

Tested the patch manually working like charm. There is no any notice error.

+1

  • johnennew committed 1e56ee4 on 8.x-1.x 
    Issue #2833884 by das-peter: Fix notice error.
das-peter’s picture

das-peter CreditAttribution: das-peter at Cando commented
Status: Reviewed & tested by the community » Fixed

I guess that's fixed then :)
@johnennewThanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.