Media browser previews full view mode even when it's restricted in WYSIWYG

Hmm, I kicked it a second time but didn't help.

Off-topic but... @LittleRedHen you don't happen to use the WYSIWYG module do you? From your digging into this issue, I was wondering if you might have any insights into #2153089: Cannot edit embedded files that don't render as images in the WYSIWYG.

More on-topic: I like the direction of the refactoring here - unfortunately I haven't had the occasion to test this though, because my site doesn't have a "full" view mode for files. I'm hoping this gets done though, because at a brief glance it seems like it removes some unnecessary code.

@LittleRedHen, disregard that question, I think I've got a handle on #2153089: Cannot edit embedded files that don't render as images in the WYSIWYG.

After applying this patch to media-7.x-2.0-rc3 this error pops up in the media browser window after uploading or selection a media to display:

Parse error: syntax error, unexpected '[' in /home/drupalpro/websites/testarchive.designmontreal.com/sites/designmontreal.com/modules/contrib/media/modules/media_wysiwyg/includes/media_wysiwyg.pages.inc on line 45 Call Stack: 0.0001 644832 1. {main}() /home/drupalpro/websites/testarchive.designmontreal.com/index.php:0 0.2333 27238296 2. menu_execute_active_handler() /home/drupalpro/websites/testarchive.designmontreal.com/index.php:21

This issue seems to be resolved in the latest 2.0. Setting the WYSIWYG default view mode for a specific file type such as at: admin/structure/file-types/manage/image
will make all media images in the WYSIWYG editor display with the selected mode. So all images will use Preview, Teaser, Default, etc. When you view the content the view mode you selected in the Media Popup will properly display.

However there is one issue I am encountering. If you use a default WYSIWYG view mode that is smaller than a view mode you select in the media popup widget, then the display mode you selected will not be used when viewing content and it will use the selected default WYSIWYG view mode (set in the admin path above).

I have tried many configuration settings, if I am missing something please let me know. Confirmed this behavior on a clean install with only media module and WYSIWYG with ckeditor being used.

> Do NOT have the undocumented media_wysiwyg_wysiwyg_default_view_mode variable set to anything.

Uh, yeah, running into this patching media_wysiwyg.pages.inc code as well.

As far as I can figure this should be an option that's set on

Media browser settings /admin/config/media/browser

Yes???

It can certainly inherit WYSIWYG view mode admin/structure/file-types/manage/image upon module install, but they are radically different things:

WYSIWYG view mode: View mode to be used when displaying files inside of the WYSIWYG editor.

media_wysiwyg_wysiwyg_default_view_mode: What the image is going to actually be displayed as on the rendered node.

As a side issue, why are both picking up display types /admin/structure/file-types/manage/image/display and neither are using Image styles /admin/config/media/image-styles?

I can't figure this out either. A recent upgrade on the 2.x branch broke this in the edit window, and I cannot figure out how to get it to show a small thumbnail. It keeps showing the original size, blowing up the modal. None of the settings have any effect.

Even though the HTML wrappers on the media item say 'preview' and 'thumbnail' - neither view mode settings are respected.

For diagnostic purpose, try this using the latest media_dev distribution by clicking on the screens i recently added to the media project page or Also on the media_dev page.

See if you can reproduce the situation , otherwise refer to the default configuration provided by media_dev

Following here, maybe we can fix the redhen patch to pass testing.

Does the patch help?

As a workaround have a look at the media_dev distribution (recently updated) simplytest.me
See link on project page

I don't know what the media_dev distro is. All I see is no way to affect the thumbnail in the media browser box like before.

Just a tidbit about the way it works for me: There's some AJAX happening whenever the user switches the view mode, and the preview changes based on what the new view mode. For example, if there were 4 allowed view modes: default, small, medium, large, then the preview will display in the modal as whatever the "default" view mode is configured as. Then if the user switches to "small", the preview changes to whatever display the "small" view mode is configured as.

I also happen to be controlling the starting view mode with a form alter. In case it's useful to anyone, this is the basic idea:

/**
 * Implements hook_form_FORM_ID_alter().
 */
function MYMODULE_form_media_wysiwyg_format_form_alter(&$form, &$form_state, $form_id) {
  $format_to_use_as_default = 'my_view_mode';
  // Any other logic to control the starting view mode...?
  $form['options']['format']['#default_value'] = $format_to_use_as_default;
}

@kevinquillen the media_dev distro is a fully functionning Media module configuration / Drupal stack , you can easily try it out simply by clicking on this link:
https://simplytest.me/project/media_dev/7.x-2.0-beta5

Follow the onscreen prompts you'll have media_dev up in running in a few mouse clicks.

From there you can run tests to see if you can reproduce the issue , or copy the working configuration options to your environment so that your environment will work.

add a node, use the wysiwyg editor, select from the media_dev library images , insert it into wysiwyg, see media project page screenshots

No, not the display. I mean in the media browser itself when previewing the image.

screenshot?

can you try repeating this on simplytest.me ?
http://simplytest.me/project/media_dev/7.x-2.0-beta5

If anyone is stumbling on this, here is what I found (no patches required).

The media browser view selects the file->image from the WYSIWYG view mode for image files. Set the size of thumbnail you want on this admin config page:

admin/structure/file-types/manage/image/file-display/wysiwyg

Recent versions of media have resolved most of peoples concerns and is compatible with entity translation, multilingual and various advanced configurations. Due to the high volume of inactive and most often irrelevant issues we are Closing this as (outdated). If for whatever reason this issue is important to you AND you still have issues after checking the media recipe documentation, then let us know and we will review your concerns.

Otherwise, see the recipe documentation for how to configure media and for troubleshooting tips OR refer to the media_dev distribution if you want to see a working media setup.

As mentioned, feel free to make some noise in this issue if you still feel it is important to you or someone else.

Thanks,

Media team