Customize fields title, url don't works [#2833300]

Comment	File	Size	Author
#10	fullcalendar-fixed_customized_fields-2833300-10.patch	4.15 KB	jrb
#9	customize_fields_title-2833300-9.patch	4.39 KB	cosolom
#8	fullcalendar-fixed_customized_fields-2833300-8.patch	2.91 KB	NickDickinsonWilde
#7	fullcalendar-fixed_customized_fields-2833300-7.patch	3 KB	jonnyeom
#6	fullcalendar-fixed_customized_fields-2833300-6.patch	3.92 KB	jonnyeom
	fix-customize-fields.patch	2.97 KB	minhtranite
#2	fullcalendar-fixed-customized-fields-2833300-2-D8.patch	2.93 KB	Delphine Lepers

Comment #1

6 December 2016 at 04:05

minhtranite created an issue. See original summary.

Log in or register to post comments

Comment #2

Delphine Lepers CreditAttribution: Delphine Lepers as a volunteer commented 21 February 2017 at 18:32

File	Size
fullcalendar-fixed-customized-fields-2833300-2-D8.patch	2.93 KB

Apply patch naming convention, fix cs

Log in or register to post comments

Comment #3

Delphine Lepers CreditAttribution: Delphine Lepers as a volunteer commented 21 February 2017 at 18:34

Log in or register to post comments

Comment #4

Delphine Lepers CreditAttribution: Delphine Lepers as a volunteer commented 21 February 2017 at 18:35

Log in or register to post comments

Comment #5

jonnyeom CreditAttribution: jonnyeom as a volunteer commented 25 July 2017 at 16:51

The patch seems to fail for Entity Link fields due to incompatibility

Here is the error.

Call to undefined method Drupal\views\Plugin\views\field\EntityLink::getItems() in Drupal\fullcalendar\Plugin\views\style\FullCalendar->prepareEvents() (line 296 of modules/contrib/fullcalendar/src/Plugin/views/style/FullCalendar.php).

Log in or register to post comments

Comment #6

jonnyeom CreditAttribution: jonnyeom as a volunteer commented 28 July 2017 at 15:23

File	Size
fullcalendar-fixed_customized_fields-2833300-6.patch	3.92 KB

Although this does not resolve the incompatibility issue mentioned in #5, I updated the patch to resolve two other things.

Undefined offset error on line 367 of fullcalendar.php
The Custom URL was not being used.

Log in or register to post comments

Comment #7

jonnyeom CreditAttribution: jonnyeom as a volunteer commented 28 July 2017 at 16:47

File	Size
fullcalendar-fixed_customized_fields-2833300-7.patch	3 KB

Accidentally added code from another patch.
Here is the patch with that extra code removed.

Log in or register to post comments

Comment #8

NickDickinsonWilde

He/Him/His

English

Victoria, BC (T'So-uke lands)

CreditAttribution: NickDickinsonWilde at BriarMoon Design for North Studio commented 30 May 2018 at 17:28

Status:

Active

» Needs review

File	Size
fullcalendar-fixed_customized_fields-2833300-8.patch	2.91 KB

4 files were hidden/shown/deleted

File	Size
fullcalendar-fixed-customized-fields-2833300-2-D8.patch	2.93 KB
fix-customize-fields.patch	2.97 KB
fullcalendar-fixed_customized_fields-2833300-6.patch	3.92 KB
fullcalendar-fixed_customized_fields-2833300-7.patch	3 KB

Rerolled with latest changes.

Log in or register to post comments

Comment #9

cosolom CreditAttribution: cosolom commented 4 July 2018 at 23:40

File	Size
customize_fields_title-2833300-9.patch	4.39 KB

1 file was hidden/shown/deleted

File	Size
fullcalendar-fixed_customized_fields-2833300-8.patch	2.91 KB

Rerolled

Log in or register to post comments

Comment #10

jrb

he/him

English

Raleigh-Durham Area, NC, USA

CreditAttribution: jrb at Jay Beaton Consulting LLC commented 12 July 2018 at 15:15

File	Size
fullcalendar-fixed_customized_fields-2833300-10.patch	4.15 KB

The patch in #9 does things differently from that in #8 and doesn't actually fix the title issue. The attached patch here does basically the same things as #8.

Log in or register to post comments

Comment #11

cosolom CreditAttribution: cosolom commented 13 July 2018 at 12:56

@jrb, maybe you right. my patch is more relevant to problem when title and url for calendar not come from basic entity of view, but from entity added by relationship.