Hi,

I have found some issues related to the coding standard.

----------------------------------------------------------------------
FOUND 14 ERRORS AND 16 WARNINGS AFFECTING 27 LINES
----------------------------------------------------------------------
100 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
| | or "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.tpl.php.".
244 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
| | or "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.tpl.php.".
330 | WARNING | [ ] Avoid backslash escaping in translatable strings
| | when possible, use "" quotes instead
365 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: )
390 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: )
393 | WARNING | [ ] Line exceeds 80 characters; contains 94
| | characters
407 | WARNING | [ ] Line exceeds 80 characters; contains 81
| | characters
483 | ERROR | [x] A cast statement must be followed by a single
| | space
590 | WARNING | [ ] Line exceeds 80 characters; contains 100
| | characters
603 | ERROR | [ ] If the line declaring an array spans longer than
| | 80 characters, each element should be broken
| | into its own line
618 | WARNING | [ ] Line exceeds 80 characters; contains 82
| | characters
635 | ERROR | [x] A cast statement must be followed by a single
| | space
679 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, or question marks
681 | ERROR | [x] Expected 1 space after IF keyword; 0 found
681 | ERROR | [x] Expected 1 space after closing parenthesis;
| | found ""
699 | WARNING | [ ] Line exceeds 80 characters; contains 107
| | characters
714 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
| | or "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.tpl.php.".
806 | ERROR | [x] Expected 1 space after IF keyword; 0 found
815 | ERROR | [x] Expected 1 space after IF keyword; 0 found
838 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 5
838 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, or question marks
906 | ERROR | [x] Doc comment long description must end with a
| | full stop
910 | WARNING | [ ] Line exceeds 80 characters; contains 99
| | characters
911 | ERROR | [x] Space found before comma in function call
919 | ERROR | [x] Space found before comma in function call
927 | WARNING | [ ] Line exceeds 80 characters; contains 99
| | characters
940 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
| | found 9
940 | WARNING | [ ] Do not concatenate strings to translatable
| | strings, they should be part of the t() argument
| | and you should use placeholders
948 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: )
956 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.",
| | or "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.tpl.php.".
----------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

I found this issues when I was run the coder.

Thank You.

CommentFileSizeAuthor
#2 coding_standard_issues-2833027-2.patch10.54 KBharivenuv
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

harivenu_zyxware created an issue. See original summary.

harivenuv’s picture

Assigned: harivenuv » Unassigned
Status: Active » Needs review
FileSize
10.54 KB

Hi,

I have created a patch to resolve this issues.

Kindly verify the patch

Thank you.

Johnny vd Laar’s picture

Status: Needs review » Fixed

Thank you for the work. I've committed your patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.