Tests! Moar tests!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tlyngej created an issue. See original summary.

jrockowitz’s picture

@tlyngej The lack of tests was one of the first things I noticed when I reviewed your module. Your solution makes sense and adding tests would confirm that it is working as expected.

tlyngej’s picture

@jrockowitz, you are right, and I am ashamed by the lack of tests!

I'll get something up here soon.

tlyngej’s picture

Status: Active » Needs review
FileSize
3.18 KB

Yay! Tests has arrived.

I have restored my honour :-)

jrockowitz’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

tlyngej’s picture

Patch committed. Thanks a lot for pushing me ;-)

  • tlyngej committed 0c33340 on 8.x-1.x
    Issue #2832671 by tlyngej, jrockowitz: Add tests
    
tlyngej’s picture

Status: Reviewed & tested by the community » Fixed
tlyngej’s picture

Assigned: tlyngej » Unassigned
tlyngej’s picture

Status: Fixed » Closed (fixed)