Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
If a message is explicitly processed via provider::incoming
or provider::send
, you should not expect to have to set the direction on the passed message object.
Each of these provider methods should set the direction.
provider::queue
should throw an exception before pre-process events if it is missing a direction.
Checking for direction prevents an issue where subscriber events assume direction to be set, but are missing the direction when processed via these method.
Comment | File | Size | Author |
---|---|---|---|
#6 | ensure-directions-2832618.patch | 7.1 KB | dpi |
|
Comments
Comment #2
dpiComment #3
dpiComment #4
almaudoh CreditAttribution: almaudoh commented+1, right now I have queued messages which are throwing Exceptions because I forgot to set the direction before testing. This should actually be an Assert not an Exception since it's not expected to be a coding omission if the direction is not set.
Comment #5
dpiadded release-8.x-1.0-beta2 tag.
Comment #6
dpihttps://github.com/dpi/smsframework/pull/65
Comment #8
dpiCommitted since there's test coverage, let me know if you spot any omissions.