Problem/Motivation

Wrong name for "JavaScript".

Proposed resolution

The supplied patch.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#13 javascript_should_be_JavaScript-2832402-13.patch20.22 KBhiramanpatil
#9 Javascript_should_be_JavaScript-2832402-8.patch7.27 KBvagelis-prokopiou
#6 Javascript_should_be_JavaScript-2832402-6.patch7.27 KBvagelis-prokopiou
#4 Javascript_should_be_JavaScript-2832402-4.patch7.28 KBvagelis-prokopiou
#2 Javascript_should_be_JavaScript-2832402-02.patch3.11 KBvagelis-prokopiou
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Vagelis created an issue. See original summary.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented
Status: Active » Needs review
FileSize
Javascript_should_be_JavaScript-2832402-02.patch3.11 KB

Status: Needs review » Needs work

The last submitted patch, 2: Javascript_should_be_JavaScript-2832402-02.patch, failed testing.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented
Status: Needs work » Needs review
FileSize
Javascript_should_be_JavaScript-2832402-4.patch7.28 KB

Updated patch file.

Status: Needs review » Needs work

The last submitted patch, 4: Javascript_should_be_JavaScript-2832402-4.patch, failed testing.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented
Status: Needs work » Needs review
FileSize
Javascript_should_be_JavaScript-2832402-6.patch7.27 KB

Status: Needs review » Needs work

The last submitted patch, 6: Javascript_should_be_JavaScript-2832402-6.patch, failed testing.

The last submitted patch, 4: Javascript_should_be_JavaScript-2832402-4.patch, failed testing.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented
Status: Needs work » Needs review
FileSize
Javascript_should_be_JavaScript-2832402-8.patch7.27 KB

Status: Needs review » Needs work

The last submitted patch, 9: Javascript_should_be_JavaScript-2832402-8.patch, failed testing.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented

If anybody can figure out why this patch fails, please do tell. I have filtered the test results and there is not a single fail or exception...
Yet it fails due to "Received a failed return code from the last command executed on the container. (Return status: 255)".

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented
Status: Needs work » Needs review
hiramanpatil’s picture

hiramanpatil CreditAttribution: hiramanpatil at Clarion Technologies commented
FileSize
javascript_should_be_JavaScript-2832402-13.patch20.22 KB

@Vagelis

I have created patch for this issue and its applied cleanly on local Drupal setup. Attached patch here.

Thanks

Status: Needs review » Needs work

The last submitted patch, 13: javascript_should_be_JavaScript-2832402-13.patch, failed testing.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented

Hello hiramanpatil. Your patch is changing "javascript" instances within the code base. That is wrong. The tests will fail.

hiramanpatil’s picture

hiramanpatil CreditAttribution: hiramanpatil at Clarion Technologies commented

so where we should change the word 'javascript' to 'JavaScript'. Please let me know.

Thanks

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented

I don't think that there is a need for a new patch. The one I provided (#9) even though it returns a CI error, passes all the tests with no fails or exceptions.