Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi,
I decided to install this module in an existing site with thousands of nodes with images which were cropped with the 'Smartcrop' module.
If you happen to flush the image cache for any given style, you will notice that the Focal Point Scale And Crop effect doesn't calculate the initial point for existing images using the Smartcrop module, even if this setting is active.
As a result, ALL images are cropped by means of the default initial point, centred in the image (50, 50).
At this point, the only option for a user would be to manually edit every node/entity an set the focal point for every image.
I think it would make a lot of sense for this module to calculate the default focal point for existing images if the setting is enabled in the backend.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | initial-focal-point-existing-images-2832030-2.patch | 679 bytes | bmunslow |
Comments
Comment #2
bmunslow CreditAttribution: bmunslow at SOCIETAT PORTAL DE LLEIDA S.L commentedPlease find attached patch that includes this functionality.
It basically runs
_focal_point_guess_defaultfunction for images which don't have a focal point set.Comment #3
bleen CreditAttribution: bleen at NBCUniversal commentedThis looks fine to me ... anyone else wanna give it a once over?
Comment #4
bleen CreditAttribution: bleen at NBCUniversal commented...for future reference, please make sure you create patches from the root of the module, not the root of your site.
Other than that, this looks good to me so I'm committing.
Thanks!
Comment #6
bleen CreditAttribution: bleen at NBCUniversal commented