rooms_unit_update_7010 update function calls commerce_update_rename_permissions function from commerce module. I am updating modules on plenty websites and came across a situation where commerce module is not enabled and rooms module is used.
Because of this database updates are not getting applied and update script ends with error Fatal error: Call to undefined function commerce_update_rename_permissions()

Can we add a check before calling that function if commerce module is enabled? Or add a dependency into the info file for commerce module.

Thoughts?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jadhavdevendra created an issue. See original summary.

acrollet’s picture

Simplest thing would be to add the dependency on commerce.

vinmassaro’s picture

Status: Active » Needs review
FileSize
1.36 KB

Ran into this today, here is a patch that fixes the issue.