Coding Standards [#2831508]

Hi!

Congrats for the module. It's excellent.
Just a few coding standards improvements.

Thanks.

Comment	File	Size	Author
#7	2831508-7.patch	19.23 KB	urvashi_vora
#7	8.x-1.x: PHP 8.0 & MySQL 5.7, D9.5 2 fail
#2	coding_standards-2831508-2.patch	15.63 KB	cebasqueira
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 9 pass PHP 5.6 & MySQL 5.5, D8.3 9 pass PHP 7 & MySQL 5.5, D8.3 9 pass PHP 8.0 & MySQL 5.7, D9.5 Patch Failed to Apply

Issue fork menu_trail_by_path-2831508

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2831508-coding-standards changes, plain diff MR !11
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 November 2016 at 17:08

cebasqueira created an issue. See original summary.

Comment #2

cebasqueira CreditAttribution: cebasqueira at CI&T commented 29 November 2016 at 18:32

Assigned:	cebasqueira	» Unassigned
Status:	Active	» Needs review

File	Size
coding_standards-2831508-2.patch	15.63 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 9 pass PHP 5.6 & MySQL 5.5, D8.3 9 pass PHP 7 & MySQL 5.5, D8.3 9 pass PHP 8.0 & MySQL 5.7, D9.5 Patch Failed to Apply

Comment #3

gfcamilo CreditAttribution: gfcamilo at CI&T commented 30 November 2016 at 13:44

Status:

Needs review

» Reviewed & tested by the community

Issue testec

Comment #4

davy-r CreditAttribution: davy-r commented 15 December 2016 at 15:40

Category:

Bug report

» Task

Comment #5

Berdir

German

Switzerland

CreditAttribution: Berdir commented 6 December 2019 at 20:42

Status:

Reviewed & tested by the community

» Needs work

+++ b/src/Menu/MenuHelperInterface.php
@@ -2,10 +2,14 @@
 
+/**
+ * Class for Menu Helper.
+ */
 interface MenuHelperInterface {
+
   /**

That's not really a useful description.

+++ b/src/Menu/MenuHelperInterface.php
@@ -2,10 +2,14 @@
-   * @param $menu_name
-   * @return \Drupal\Core\Menu\MenuLinkInterface[]
+   * {@inheritdoc}
    */
   public function getMenuLinks($menu_name);

This can't use inheritdoc because it's actually the interface, there's nothing to inherit from.

+++ b/src/Menu/MenuTreeStorageMenuHelper.php
@@ -5,21 +5,25 @@ namespace Drupal\menu_trail_by_path\Menu;
   /**
-   * @var MenuLinkManagerInterface
+   * {@inheritdoc}
    */
   protected $menuLinkManager;
 
   /**
-   * @var MenuTreeStorageInterface
+   * {@inheritdoc}
    */
   protected $menuTreeStorage;

also not correct, they are not inherited. what it needs is a description instead.

Same for many more changes.