Problem/Motivation

#2561115: Rollback: Use 'Filter' for exposed filter button text in new views and new installations (instead of 'Apply') changed the default submit button text for exposed filters from Apply to Filter.
Let's discuss whether we want an update path for that.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2831017-2.patch1.87 KBLendude
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

Lendude’s picture

xjm’s picture

Title: Potential update path for 2561115 » Potential update path for changing exposed filter button text to 'Filter'

Clarifying the title. Thanks for filing this!

dawehner’s picture

  1. +++ b/core/modules/views/views.post_update.php
    @@ -239,3 +239,51 @@ function views_post_update_boolean_filter_values() {
    +  $core_admin_views = [];
    +
    +  // Find all the core Views with an admin path.
    +  foreach ($config_factory->listAll('views.view.') as $view_config_name) {
    +    $view = $config_factory->get($view_config_name);
    +    if ($view->get('_core')) {
    +      foreach ($view->get('display') as $display_id => $display) {
    +        if (!empty($display['display_options']['path']) && strpos($display['display_options']['path'], 'admin/') === 0) {
    +          $core_admin_views[] = $view_config_name;
    +        }
    +      }
    +    }
    +  }
    

    Mhhh, so wouldn't this break if there is one admin and one non admin display? Maybe we should collect combinations of view ID and display ID.

  2. +++ b/core/modules/views/views.post_update.php
    @@ -239,3 +239,51 @@ function views_post_update_boolean_filter_values() {
    +    $view = $config_factory->getEditable($view_config_name);
    

    Note: We are in post update land, in which we could use the actual entity api again. This might make things a bit easier here.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

Status: Needs review » Closed (won't fix)

#2561115: Rollback: Use 'Filter' for exposed filter button text in new views and new installations (instead of 'Apply') was reverted and recommended to be fixed/wontfix, so closing this one wontfix explicitly. Thanks!