Currently this module contains lots of code style violations.

CommentFileSizeAuthor
#16 fixing_code_style-2830843-16.patch8.99 KBchr.fritsch
#13 interdiff-2830843-12-13.txt586 byteschr.fritsch
#13 fixing_code_style-2830843-13.patch22.12 KBchr.fritsch
#12 fixing_code_style-2830843-12.patch21.64 KBchr.fritsch
#10 dropzonejs-fix-code-style-violations-2830843-10-D8.patch21.51 KBDimiter
#5 fixing_code_style-2830843-5.patch16.95 KBchr.fritsch
#2 fixing_code_style-2830843-2.patch16.56 KBchr.fritsch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Active » Needs review
FileSize
fixing_code_style-2830843-2.patch16.56 KB

#2690943: Remove deprecated methods in code base, #2767047: Remove @file tag docblock from all the .php files. and #2745745: Removing unused imports in code are outdated and can be closed when this is committed.

Status: Needs review » Needs work

The last submitted patch, 2: fixing_code_style-2830843-2.patch, failed testing.

The last submitted patch, 2: fixing_code_style-2830843-2.patch, failed testing.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
FileSize
fixing_code_style-2830843-5.patch16.95 KB

Fixing tests

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs work » Needs review
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Issue tags: +D8Media
Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
Status: Needs review » Needs work

Meh, didn't see this and committed #2767047: Remove @file tag docblock from all the .php files..

#2745745: Removing unused imports in code is outdated and you added a patch for #2690943: Remove deprecated methods in code base It seems best to commit the code there and if this patch contains additional more stuff this will need a re-roll.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Issue tags: +dcmuc16

#2767047: Remove @file tag docblock from all the .php files. and #2690943: Remove deprecated methods in code base are committed. This needs a re-roll

Dimiter’s picture

Dimiter CreditAttribution: Dimiter at One Shoe commented
Status: Needs work » Needs review
FileSize
dropzonejs-fix-code-style-violations-2830843-10-D8.patch21.51 KB

How about this supplied patch? Both PHPCS and ESLint don't report any violations any more.

mtodor’s picture

mtodor CreditAttribution: mtodor at Thunder commented

I have checked (reviewed) this:

  1. Changes look good
  2. PHPCS is fine
  3. ESLint is fine
  4. I have also tested module a bit, just to be sure something is not broken -> and it looks fine

So from my perspective, this can be committed.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
FileSize
fixing_code_style-2830843-12.patch21.64 KB

Needs a reroll. Lets see

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
FileSize
fixing_code_style-2830843-13.patch22.12 KB
interdiff-2830843-12-13.txt586 bytes

Hopefully last round to fix DrupalPractice coding style

  • chr.fritsch committed 163b0a2 on 8.x-1.x 
    Issue #2830843 by chr.fritsch, Dimiter: Fixing code style violations
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs review » Fixed

Thanks everyone.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Fixed » Needs review
FileSize
fixing_code_style-2830843-16.patch8.99 KB

After updating my coder lib, i discovered that there is much more

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs review » Fixed

Ok, all CS are fixed now

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.