Followup to #2010898: Use tokens for entity selection view arguments:
* Use token for entity selection view arguments
* Add a token that sometimes is empty (and is not the last if that matters)
* Have that argument "display all if empty"

This makes views display nothing instead of all items.

CommentFileSizeAuthor
#2 entityreference-2830703-2-Empty-token-break.patch1.09 KBgeek-merlin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

axel.rutz created an issue. See original summary.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at Clever Systems, MachbarMacher, DruConsult commented
Status: Active » Needs review
FileSize
entityreference-2830703-2-Empty-token-break.patch1.09 KB

Patch flying in that fixes this issue for me.
It extends the "pass 0" logic for empty entity IDs to all other empty args.
(I'm not too happy with this, but i don't expect the underlying views question will ever be fixed in D7.)
(Quite some people consider anything that views does after such a long time a feature not a bug ;-)

MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented

Is this related to, or a duplicate of #2815863: Contextual filter values of "" don't trigger "When the filter value is NOT available"?

cmseasy’s picture

cmseasy CreditAttribution: cmseasy commented

Patch worked for me, thanks

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

The solution in #2 seems like it needs more thourough debug into the root cause. Setting all the empty values to 0, should be done in views if it's really correct way forward.

david.qdoscc’s picture

david.qdoscc CreditAttribution: david.qdoscc commented

For me this patch still didn't address the issue with [node:nid] resulting in an error Notice: Undefined property: stdClass::$nid in node_tokens()

I did get around this by using [current-page:url:unaliased:args:value:N] instead of [node:nid] to pass the ID when editing existing content but pass a 0 when adding new content.

Pancho’s picture

Pancho
Location UTC+2 🇪🇺 EU
CreditAttribution: Pancho as a volunteer commented
Related issues: +#2815863: Contextual filter values of "" don't trigger "When the filter value is NOT available"
marksmith’s picture

marksmith CreditAttribution: marksmith commented

Solution #6 works if (A) entity reference field widget type is (multiple value) select list, but not with (B) ER multiple value autocomplete field (with Add more button). (B) is preferred in some cases where selected value order is important.