Hello,

With Drupal and Drush 8, it is now possible to update translations without l10n_update.

I also think to add a support for drush_language and its options.

Is this feature already planned or can I try to make a patch for that?

CommentFileSizeAuthor
#10 hosting_tasks_extra-update_translations-2830562-10.patch4.26 KBgrimreaper
#8 hosting_tasks_extra-update_translations-2830562-8.patch4.5 KBgrimreaper
#4 hosting_tasks_extra-update_translations-2830562-4.patch4.55 KBgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Category: Bug report » Feature request

Wrong Category.

helmo’s picture

helmo commented

I've not heard of anyone working on that... so go for it :)

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs review
StatusFileSize
new hosting_tasks_extra-update_translations-2830562-4.patch4.55 KB

Hello,

Here is a patch that adds this feature.

The only "problem" I am not satisfied with is that I have duplicated the function _hosting_sync_site_has_module() into _hosting_tasks_extra_site_has_module() to avoid a dependency on hosting_sync module.

Thanks for the review.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Also, I think to maybe create a separated module to integrate with the drush_language extension.

I imagine a scan of the platform to detect the .po files and then being able to select which po file to import.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Project: Hostmaster (Aegir) » Aegir Hosting Tasks Extra

I forgot to change project.

helmo’s picture

helmo commented
Status: Needs review » Needs work

Cool

+1 for moving _hosting_sync_site_has_module to the core hosting_site module so it can be used in both places.

The core_major_version check from #2830557: Support for --entity-updates option on drush updb command might be useful here too... that also sounds like a nice addition for core.

PS: the patch still calls _hosting_sync_site_has_module() ;)

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Needs review
StatusFileSize
new hosting_tasks_extra-update_translations-2830562-8.patch4.5 KB

Hello,

Thanks @helmo for catching that. here is a rework of the patch.

I will open an issue and provide a patch for the refactoring of the _hosting_sync_site_has_module() function.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Parent issue: » #2832110: Refactoring of _hosting_sync_site_has_module

I will redo the patch when #2832110: Refactoring of _hosting_sync_site_has_module will be ok.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
StatusFileSize
new hosting_tasks_extra-update_translations-2830562-10.patch4.26 KB

Hello,

Here is the updated patch as the issue #2832110: Refactoring of _hosting_sync_site_has_module is fixed.

helmo’s picture

helmo commented
Status: Needs review » Reviewed & tested by the community

Thanks, I just did some basic testing... looks OK.

helmo’s picture

helmo commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Thanks @helmo.

But I don't see the commit in the repository: http://cgit.drupalcode.org/hosting_tasks_extra/log

Not pushed yet?

  • helmo committed 8472a68 on 7.x-3.x authored by Grimreaper 
    Issue #2830562 by Grimreaper: Update translations on managed sites
helmo’s picture

helmo commented

I must have been distracted ... it's pushed now.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Thanks @helmo.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.