Problem/Motivation

Discovered in #2712647: Update Symfony components to ~3.2 that the naming of this class should be changed.

Proposed resolution

Create new class with new name, old class extends the new one and gets deprecated.

Remaining tasks

Patch

API changes

A class gets renamed that is not part of our public API, so no public API change.

CommentFileSizeAuthor
#5 interdiff-3-5.txt3.1 KBrosinegrean
#5 rename_CommandLineOrUnsafeMethod-2830451-5.patch2.26 KBrosinegrean
#3 rename_CommandLineOrUnsafeMethod-2830451-3.patch2.23 KBrosinegrean
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klausi created an issue. See original summary.

rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
Assigned: Unassigned » rosinegrean
rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
Assigned: rosinegrean » Unassigned
Status: Active » Needs review
FileSize
rename_CommandLineOrUnsafeMethod-2830451-3.patch2.23 KB

Is there something else required for this ?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Title: Rename class CommandLineOrUnsafeMethod to CommandLineOrUncachableMethod » Rename class CommandLineOrUnsafeMethod to CommandLineOrUncacheableMethod
Status: Needs review » Postponed

Looks good!

  1. +++ b/core/lib/Drupal/Core/PageCache/RequestPolicy/CommandLineOrUncachableMethod.php
@@ -0,0 +1,33 @@
+class CommandLineOrUncachableMethod implements RequestPolicyInterface {

    sorry, I think it should be uncacheable with an "e". 

  2. +++ b/core/lib/Drupal/Core/PageCache/RequestPolicy/CommandLineOrUnsafeMethod.php
@@ -11,23 +11,9 @@
+ *
+ * @deprecated Class renamed in issue https://www.drupal.org/node/2830451

    this should follow the usual "@deprecated Scheduled for removal in Drupal 9.0.0. Use instead." pattern.

But let's wait for #2712647: Update Symfony components to ~3.2 to be committed first.

rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
FileSize
rename_CommandLineOrUnsafeMethod-2830451-5.patch2.26 KB
interdiff-3-5.txt3.1 KB

So for the moment i've updated the patch.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.