Page manager context argument allows you to add page contexts of page variants from page manager to be set as default arguments for views. I came across this solution after facing the issue given at following link:

https://www.drupal.org/node/2287073

This module adds new option "Page manager context" under default arguments drop down for contextual filters of views. Currently it supports only context of type "any".

Dependencies:

  1. Page Manager
  2. Views

Project Page

https://www.drupal.org/sandbox/patilvishalvs/2830217

Pareview Results

https://pareview.sh/node/135

Manual review of other projects

https://www.drupal.org/node/2828790#comment-11794745
https://www.drupal.org/node/2829972#comment-11805410

Clone Repository

 git clone --branch 8.x-1.x https://git.drupal.org/sandbox/patilvishalvs/2830217.git page_manager_context_argument
cd page_manager_context_argument 

Comments

patilvishalvs created an issue. See original summary.

patilvishalvs’s picture

Issue summary: View changes
patilvishalvs’s picture

Issue summary: View changes
PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

rjjakes’s picture

Automated Review

[Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a lot, then post a link to the automated review and mention that problems should be addressed.]

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Issues:
Git default branch is not set, see the documentation on setting a default branch. https://www.drupal.org/node/1659588

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause] module duplication and/or fragmentation.
Master Branch
[No: Does not follow] the guidelines for master branch.

See above, or: https://www.drupal.org/node/1659588

Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Does not following the README template: https://www.drupal.org/node/2181737

Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
[Yes: Meets the security requirements.]
Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. (*) Major finding, needs work
  2. (+) Release blocker
  3. Just a recommendation
  4. ...]
  1. If I create an existing "Any data" context within page manager and then enable the module, it does not appear in the Page Manager list when editing the views contextual filters (just a suggestion)

Other than that the module works great with no functional issues.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

rjjakes’s picture

Status: Active » Needs work
patilvishalvs’s picture

Status: Needs work » Needs review

Dear rjjakes,

Thank you for sharing your feedback. Please check following response:

  1. Added default branch
  2. Master branch is as per Pareview.sh feedback, when I added master branch and did automated test, it asked me to remove master branch
  3. Updated README.txt
  4. Please elaborate:
    If I create an existing "Any data" context within page manager and then enable the module, it does not appear in the Page Manager list when editing the views contextual filters (just a suggestion)
patilvishalvs’s picture

Issue summary: View changes
mxh’s picture

Now that https://www.drupal.org/node/2287073 has been finally fixed, would you still like to continue the project application process?

patilvishalvs’s picture

Status: Needs review » Closed (outdated)

Closing this project application process as the requirement is fixed in Drupal core(https://www.drupal.org/node/2287073).