Cache_clear_all is not clearing cache data, only expired [#2829833]

In authcache.admin.inc cache_clear_all on line 276 is just set as,
cache_clear_all();

Which will expire only stale data. As button says on form "clear cached data" it should be as the one on line 139, and clear
cache_clear_all('*', 'cache_page', TRUE);

So I made a patch to make this the same as this second form "authcache_admin_pagecaching" is not clearing cache the way we expect it to be.

Comment	File	Size	Author
#2	proper_cache_clear-2829833-1.patch	427 bytes	Marko B
#2	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 241 pass PHP 5.4 & MySQL 5.5, D7 241 pass PHP 5.5 & MySQL 5.5, D7 241 pass PHP 5.6 & MySQL 5.5, D7 241 pass PHP 7 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 November 2016 at 23:18

Marko B created an issue. See original summary.

Comment #2

Marko B CreditAttribution: Marko B commented 22 November 2016 at 23:19

File	Size
proper_cache_clear-2829833-1.patch	427 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 241 pass PHP 5.4 & MySQL 5.5, D7 241 pass PHP 5.5 & MySQL 5.5, D7 241 pass PHP 5.6 & MySQL 5.5, D7 241 pass PHP 7 & MySQL 5.5, D7 Skipped, branch did not pass for 4 weeks

Comment #3

Marko B CreditAttribution: Marko B commented 31 March 2017 at 08:24

Status:

Active

» Needs review

Comment #4

znerol CreditAttribution: znerol commented 12 April 2017 at 14:59

Status:

Needs review

» Needs work

In my opinion cache_clear_all(); (without any parameters) is the correct way to clear the page cache. This is also what is used in Drupal core (see, e.g. node_admin_nodes_submit).

Not specifying any parameter will remove expired and temporary items from the page cache as well as the block cache. Since Authcache saves cached pages as temporary items, those get nuked.

Hence, IMHO the line in 139 is actually wrong and needs a fix.

Comment #5

Marko B CreditAttribution: Marko B commented 14 April 2017 at 09:20

From out use case, we usually want to clear ALL cache from authcache, which is in stored in redis. Not only expired ones as this will prevent from changes beeing shown.
Seems to me like authcache should have different logic as when you change something on site, its not propagated to autcache as expired, right?