Problem/Motivation

We need better logging, so we can debug issues when problems arise without requiring a dev.

Proposed resolution

Improve logging of requests, responses and errors.

Remaining tasks

Check patch is green

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#6 2829739-6.patch14.22 KBpenyaskito
#6 interdiff.txt601 bytespenyaskito
#3 2829739-3.patch13.63 KBpenyaskito
#3 interdiff.txt3.31 KBpenyaskito
#2 2829739-2.patch13.95 KBpenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Active » Needs review
FileSize
2829739-2.patch13.95 KB

Patch attached

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
FileSize
interdiff.txt3.31 KB
2829739-3.patch13.63 KB

Removed unnecessary json parsing.

The last submitted patch, 2: 2829739-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2829739-3.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs work » Needs review
FileSize
interdiff.txt601 bytes
2829739-6.patch14.22 KB

Fixed test error.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs review » Reviewed & tested by the community

Tests passed as expected.

  • penyaskito committed 3f9e8f0 on 8.x-1.x 
    Issue #2829739 by penyaskito: Improve logging of requests, responses and...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Reviewed & tested by the community » Fixed

Committed 3f9e8f0 and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.