warnings after upgrading to 7.x-1.12

Hi, thanks for the report. Looking at the other plugins, the pattern is to not include any path in the icon filename.
Could you confirm if editing node_book_nav.inc like this works (i.e. there's still an icon in the admin pages) and makes the error go away?

+  $booknavicon = ctools_plugin_get_directories(ctools_plugin_get_info('ctools', 'content_type'));
+  $booknavicon = $booknavicon['block'] . '/icon_core_booknavigation.png';
  $plugin = array(
     'single' => TRUE,
     'title' => t('Book navigation pager'),
-    'icon' => '../block/icon_core_booknavigation.png',
+    'icon' =>  $booknavicon,
     'description' => t('The navigational pager and sub pages of the current book node.'),
     'required context' => new ctools_context_required(t('Node'), 'node'),
     'category' => t('Node'),

[Please note - this is not intended as a final patch, just as a test]

I've also had similar warnings. Although the book modules was installed on this particular site, there was no content actually using it. So I fixed the warnings by disabling the book module.

Not sure if it's relevant to your change but before I disabled the module I did try your code above but got.

Undefined index: module in ctools_plugin_get_directories() (line 527 of /var/www/vhosts/readyweb-servers.co.uk/drupal.7/html/sites/all/modules/ctools/includes/plugins.inc).

Undefined index: type in ctools_plugin_get_directories() (line 527 of /var/www/vhosts/readyweb-servers.co.uk/drupal.7/html/sites/all/modules/ctools/includes/plugins.inc).

Undefined index: block in include_once() (line 9 of /var/www/vhosts/readyweb-servers.co.uk/drupal.7/html/sites/all/modules/ctools/plugins/content_types/node_context/node_book_nav.inc).

If it would be any help I could try something else as I think my matching dev server version should be able to duplicate this.

Same problem to me, with book module enabled.

This is my quick and dirty fix:

<?php
  $plugin = array(
    'single' => TRUE,
    'title' => t('Book navigation pager'),
-    'icon' => '../block/icon_core_booknavigation.png',
+   'icon' => drupal_get_path('module', 'ctools') . '/plugins/content_types/block/icon_core_booknavigation.png',
    'description' => t('The navigational pager and sub pages of the current book node.'),
    'required context' => new ctools_context_required(t('Node'), 'node'),
    'category' => t('Node'),
  );
?>

same problem for another file

Warning: file_exists(): open_basedir restriction in effect. File(../block/icon_core_block_menu.png) is not within the allowed path(s): (/var/www/clients/client1/web1/web:/var/www/clients/client1/web1/private:/var/www/clients/client1/web1/tmp:/var/www/xxx.com/web:/srv/www/xxx.com/web:/usr/share/php5:/usr/share/php:/tmp:/usr/share/phpmyadmin:/etc/phpmyadmin:/var/lib/phpmyadmin) in ctools_content_admin_icon() (linea 419 di /var/www/clients/client1/web1/web/sites/all/modules/ctools/includes/content.inc).

dirty fix:

<?php
  $plugin = array(
    'single' => TRUE,
    'title' => t('Book navigation menu'),
-    'icon' => '../block/icon_core_block_menu.png',
+    'icon' => drupal_get_path('module', 'ctools') . '/plugins/content_types/block/icon_core_block_menu.png',
    'description' => t('The book menu belonging to the current book node.'),
    'required context' => new ctools_context_required(t('Node'), 'node'),
    'category' => t('Node'),
  );
?>

Would the best solution be to copy or move the book navigation icons into the correct plugin folder so they can be accessed locally?

For convenience I did the patch either modifice code in the comments #7 and #8.

Changing status to "Needs review"

Code checks out RTBC

Pretty straightforward. Fixed!