Changes made by code are not synchronized with ui [#2829614]

Hi,

i have a site with 2 differents domains, local.site1.com and local.site2.com.
My aim is to set 2 different themes for the domain. To do that, i created 2 different files:
-domain.config.local_site1_com.system.theme.yml
-domain.config.local_site2_com.system.theme.yml
setting in first domain, just to try, bartik as theme and in the second cog as theme.

It worked, but only looking the pages directly. The configuration at admin/appearance remains the same as before.

The same concerning site info: at admin/config/system/site-information i cannot see the changes made.
It would be useful to have a interface where to set all these things, so themes, site info, email, slogan, metatags ecc.

Comment	File	Size	Author
#3	domain_config_ui-2829614-3.patch	24.2 KB	kalpaitch

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 November 2016 at 11:24

sanci created an issue. See original summary.

Comment #2

kalpaitch CreditAttribution: kalpaitch commented 20 December 2016 at 11:42

This bug is related to the fact that the domain_config module has no UI, but the config it overrides does. There are patches for this here - https://github.com/agentrickard/domain/pull/294/files - please consider these. Thanks.

Comment #3

kalpaitch CreditAttribution: kalpaitch commented 20 December 2016 at 11:56

File	Size
domain_config_ui-2829614-3.patch	24.2 KB

I'm just attaching this here as a patch so that we can use it in our composer files.

Comment #4

kalpaitch CreditAttribution: kalpaitch commented 20 December 2016 at 12:31

Status:

Active

» Needs review

Comment #5

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani commented 21 December 2016 at 11:23

I have used this and it helps a lot.
Without this module I had to manually create the yml files. This is very handy, thank you for the initiative.

Also, this module fixes the following problem with the edit form:
- When I am on a subdomain and go admin/config/system/site-information, the form doesn't read the configuration from the subdomain specific yml file.

Comment #6

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 23 December 2016 at 19:02

@marcelovani yes, this is a very complex issue. See the active work that @davidgrayson is doing in https://github.com/agentrickard/domain/pull/294.

As I understand it, core doesn't handle the use case of "viewing a form that has overridden values" so the Domain Config UI module tries to solve that problem.

Comment #7

kalpaitch CreditAttribution: kalpaitch commented 28 December 2016 at 10:58

Yes, I took @davidgrayson's pr there and made it a patch on d.o. Primarily so that we can use it in our composer files but also in the hope that it is committed to this branch. Cheers.

Comment #8

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani commented 4 January 2017 at 14:43

I think this PR is quite useful as is. Not the final solution but good enough as a starting point.

I would suggest to accept the PR and continue development. We will benefit right away. The good thing is that being a separate module it won't cause any harm.

One thing I would like to add to it is the ability to choose which forms I want to alter.

Comment #9

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 4 January 2017 at 21:34

I'd like to see at least one test before committing that code.

Comment #10

marcelovani

Portuguese, Brazil

London

CreditAttribution: marcelovani commented 6 January 2017 at 12:00

@sanci Does this patch resolve your problem?

Comment #11

sanci91 CreditAttribution: sanci91 commented 9 January 2017 at 09:47

@marcelovani, i'm currently not using domain module because i have to integrate it with acquia lightning and blt and i'm not managing to do it. But this is another issue not linked with this one. As soon as i could i'll try on a project in locale and let you know.