Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Needs tests of core pipeline functionality.
Comment | File | Size | Author |
---|---|---|---|
#37 | 2829539-37.patch | 15.05 KB | jcisio |
| |||
#35 | 2829539-interdiff-35.txt | 3.42 KB | jcisio |
#35 | 2829539-tests-35.patch | 15 KB | jcisio |
#34 | imageapi_optimize-add_pipeline_kernel_tests-2829539-34.patch | 15.08 KB | Steven Jones |
|
Comments
Comment #2
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedJust want to see if this will get tested.
Comment #4
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedAdd a fix for the config schema
Comment #5
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedAdded those tests from core that should generally make sure that we've not broken core functionality.
Need to add our tests.
Comment #7
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedHere's an overridden core simpletest to see if this sort of thing will work.
Comment #9
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #10
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #12
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #13
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #14
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #16
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #18
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedCopy over all of the tests.
Comment #19
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #21
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #24
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #26
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedNow that we have the core tests, we should actually write some tests that use pipelines too.
Comment #27
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedI think I'll need this to be a Kernel test.
Rough plan of what could be tested;
Comment #28
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedHere's a very initial unit test just for a single invocation of advpng, just to make sure I'm writing them in the correct way for d.o to run them.
Comment #29
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedHmm...fairly certain that drupal.org didn't actually find the test added in that patch.
Comment #30
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedTry putting the test file in the correct location.
Comment #31
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedThat's better, now need to make the test actually do something.
Comment #32
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedComment #33
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedAdding a base class for the tests, and tests for AdvDef and AdvPng
Comment #34
Steven Jones CreditAttribution: Steven Jones at ComputerMinds commentedFixup those tests, hopefully.
Comment #35
jcisio CreditAttribution: jcisio at Axess Open Web Services commentedFixed some typos.
Comment #37
jcisio CreditAttribution: jcisio at Axess Open Web Services commentedComment #39
jcisio CreditAttribution: jcisio at Axess Open Web Services commented