Needs tests of core pipeline functionality.

CommentFileSizeAuthor
#37 2829539-37.patch15.05 KBjcisio
#35 2829539-interdiff-35.txt3.42 KBjcisio
#35 2829539-tests-35.patch15 KBjcisio
#34 imageapi_optimize-add_pipeline_kernel_tests-2829539-34.patch15.08 KBSteven Jones
#33 imageapi_optimize-add_pipeline_kernel_tests-2829539-33.patch15.07 KBSteven Jones
#32 imageapi_optimize-add_pipeline_kernel_tests-2829539-32.patch11.05 KBSteven Jones
#30 imageapi_optimize-add_pipeline_kernel_tests-2829539-30.patch8.85 KBSteven Jones
#28 imageapi_optimize-add_pipeline_kernel_tests-2829539-28.patch8.95 KBSteven Jones
#24 imageapi_optimize-2829539-test-tests.patch14.32 KBSteven Jones
#21 imageapi_optimize-2829539-test-tests.patch13.82 KBSteven Jones
#19 imageapi_optimize-2829539-test-tests.patch13.33 KBSteven Jones
#18 imageapi_optimize-2829539-test-tests.patch13.05 KBSteven Jones
#16 imageapi_optimize-2829539-test-tests.patch8.58 KBSteven Jones
#12 imageapi_optimize-2829539-test-tests.patch5 KBSteven Jones
#10 imageapi_optimize-2829539-test-tests.patch2.45 KBSteven Jones
#9 imageapi_optimize-2829539-test-tests.patch1.87 KBSteven Jones
#7 imageapi_optimize-2829539-test-tests.patch496 bytesSteven Jones
#4 imageapi_optimize-2829539-test-tests.patch33.62 KBSteven Jones
#2 imageapi_optimize-2829539-test-tests.patch32.94 KBSteven Jones
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Steven Jones created an issue. See original summary.

Steven Jones’s picture

Status: Active » Needs review
FileSize
32.94 KB

Just want to see if this will get tested.

Status: Needs review » Needs work

The last submitted patch, 2: imageapi_optimize-2829539-test-tests.patch, failed testing.

Steven Jones’s picture

Status: Needs work » Needs review
FileSize
33.62 KB

Add a fix for the config schema

Steven Jones’s picture

Status: Needs review » Needs work

Added those tests from core that should generally make sure that we've not broken core functionality.

Need to add our tests.

  • Steven Jones committed d57a0fa on 8.x-2.x
    Issue #2829539 by Steven Jones: Add core unit tests
    
Steven Jones’s picture

Here's an overridden core simpletest to see if this sort of thing will work.

Status: Needs review » Needs work

The last submitted patch, 7: imageapi_optimize-2829539-test-tests.patch, failed testing.

Steven Jones’s picture

Status: Needs work » Needs review
FileSize
1.87 KB
Steven Jones’s picture

The last submitted patch, 9: imageapi_optimize-2829539-test-tests.patch, failed testing.

Steven Jones’s picture

Steven Jones’s picture

Status: Needs review » Needs work
Steven Jones’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: imageapi_optimize-2829539-test-tests.patch, failed testing.

Steven Jones’s picture

Status: Needs work » Needs review
FileSize
8.58 KB

Status: Needs review » Needs work

The last submitted patch, 16: imageapi_optimize-2829539-test-tests.patch, failed testing.

Steven Jones’s picture

Status: Needs work » Needs review
FileSize
13.05 KB

Copy over all of the tests.

Steven Jones’s picture

The last submitted patch, 18: imageapi_optimize-2829539-test-tests.patch, failed testing.

Steven Jones’s picture

The last submitted patch, 19: imageapi_optimize-2829539-test-tests.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 21: imageapi_optimize-2829539-test-tests.patch, failed testing.

Steven Jones’s picture

Status: Needs work » Needs review
FileSize
14.32 KB

  • Steven Jones committed 137e276 on 8.x-2.x
    Issue #2829539 by Steven Jones: Add pipeline unit tests
    
Steven Jones’s picture

Status: Needs review » Needs work

Now that we have the core tests, we should actually write some tests that use pipelines too.

Steven Jones’s picture

Title: Add pipeline unit tests » Add pipeline Kernel tests

I think I'll need this to be a Kernel test.

Rough plan of what could be tested;

  • Have a test image processor plugin that strips metadata or just truncates the file to zero bytes or somesuch
  • Spin up an image pipeline and add no processors to it
  • Spin up an image pipeline and add an instance of the test image processor
  • Apply both of the above pipelines to an image file in a virtual filesystem, asserting that the first does nothing, and the second does what its supposed to do.
  • unit test each of the image processors to assert that the correct command is called given all the options etc.
Steven Jones’s picture

Here's a very initial unit test just for a single invocation of advpng, just to make sure I'm writing them in the correct way for d.o to run them.

Steven Jones’s picture

Hmm...fairly certain that drupal.org didn't actually find the test added in that patch.

Steven Jones’s picture

Steven Jones’s picture

Status: Needs review » Needs work

That's better, now need to make the test actually do something.

Steven Jones’s picture

Steven Jones’s picture

Adding a base class for the tests, and tests for AdvDef and AdvPng

Steven Jones’s picture

jcisio’s picture

Status: Needs review » Needs work

The last submitted patch, 35: 2829539-tests-35.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jcisio’s picture

Status: Needs work » Needs review
FileSize
15.05 KB

  • jcisio committed c2b73c1 on 8.x-2.x
    Issue #2829539 by Steven Jones, jcisio: Add pipeline Kernel tests
    
jcisio’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.