Problem/Motivation

Entity browser added "auto open" functionality to Modal display in #2778305: Open entity browser with one click from Entity Browser IEF widget.

Media browser seems to be having some unrelated config variables in display configuration: display_configuration.auto_open. This happens to match the config variable that the new functionality is using, which causes unwanted behavior (modals open automatically when page is loaded).

Proposed resolution

Update config that is shipped with the module to remove unneeded values and disable auto open for modals. Also update existing config via an update hook.

I propose that we release a new alpha after this lands and mention this problem in release notes.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slashrsm created an issue. See original summary.

slashrsm’s picture

Status: Active » Needs review
FileSize
1.23 KB
kjauslin’s picture

das-peter’s picture

Status: Needs review » Reviewed & tested by the community

FYI Change from kjauslin is:
+function file_browser_update_8001() { to
+function media_update_8001() {

Code otherwise looks good - and seems to work as advertised: so call it RTBC maybe? :)

Anybody’s picture

Confirming #3 RTBC after manual patch. This patch is important so it would be cool to have it committed. Otherwise you'll have heavy overlay of modals and happy users clicking them away ;).

Thank you very much.

secretsayan’s picture

This patch works...RTBC +1

joseph.olstad’s picture

Status: Reviewed & tested by the community » Closed (won't fix)

if you want to use media related functionality in D8 you should upgrade to 8.4.x , there is media-like functionality in D8 core now.
as for media 8.x, see the project page for more details : http://drupal.org/project/media