Problem/Motivation
Entity browser added "auto open" functionality to Modal display in #2778305: Open entity browser with one click from Entity Browser IEF widget.
Media browser seems to be having some unrelated config variables in display configuration: display_configuration.auto_open
. This happens to match the config variable that the new functionality is using, which causes unwanted behavior (modals open automatically when page is loaded).
Proposed resolution
Update config that is shipped with the module to remove unneeded values and disable auto open for modals. Also update existing config via an update hook.
I propose that we release a new alpha after this lands and mention this problem in release notes.
Comment | File | Size | Author |
---|---|---|---|
#3 | media-modal_opens_automatically-2829473_3.patch | 1.22 KB | kjauslin |
#2 | 2829473_2.patch | 1.23 KB | slashrsm |
Comments
Comment #2
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedComment #3
kjauslin CreditAttribution: kjauslin commentedComment #4
das-peter CreditAttribution: das-peter at Cando commentedFYI Change from kjauslin is:
+function file_browser_update_8001() {
to+function media_update_8001() {
Code otherwise looks good - and seems to work as advertised: so call it RTBC maybe? :)
Comment #5
AnybodyConfirming #3 RTBC after manual patch. This patch is important so it would be cool to have it committed. Otherwise you'll have heavy overlay of modals and happy users clicking them away ;).
Thank you very much.
Comment #6
secretsayan CreditAttribution: secretsayan commentedThis patch works...RTBC +1
Comment #7
joseph.olstadif you want to use media related functionality in D8 you should upgrade to 8.4.x , there is media-like functionality in D8 core now.
as for media 8.x, see the project page for more details : http://drupal.org/project/media