libraries-override paths needs to be changed if they are base vs subtheme [#2829372]

Problem/Motivation

The path logic is painful when using sub themes to overwriting libraries.

Lets say we have 2 themes : base and subtheme
If I want to remove the toolbar.theme.css in my basetheme (base) and i set my active theme set to "subtheme"

name: base
type: theme
base theme: classy

libraries-override:
  toolbar/toolbar:
    css:
      theme:
        css/toolbar.theme.css: false

subtheme:

name: subtheme
type: theme
base theme: base
core: '8.x'

Oki so that works fine toolbar.theme.css is removed when i use my subtheme, and it "inherits" the removing of toolbar.theme.css

But if I wanna do the same with a the theme that do not uses a subtheme i have to change the paths

name: basedrop
type: theme
base theme: stable # or classy
core: '8.x'

libraries-override:
  toolbar/toolbar:
    css:
      theme:
        /core/themes/stable/css/toolbar/toolbar.theme.css: false

The path for toolbar.theme.css have to be set to now to /core/themes/stable/css/toolbar/toolbar.theme.css instead of css/toolbar.theme.css: false thats kinda confusing

Proposed resolution

make paths for overwriting core allways be the same path

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Comment #1

21 November 2016 at 16:28

mortendk created an issue. See original summary.

Comment #2

mortendk CreditAttribution: mortendk as a volunteer commented 21 November 2016 at 16:35

Issue summary:

View changes

Comment #3

mortendk CreditAttribution: mortendk as a volunteer commented 21 November 2016 at 19:57

Issue summary:

View changes

Comment #4

vdanielpop CreditAttribution: vdanielpop as a volunteer and at PitechPlus commented 25 November 2016 at 11:40

How do you think this should work? The specified file should be taken into consideration only when a file with the same path doesn't exist in the current theme's directory?
That doesn't feel quite right.

Comment #5

almaudoh CreditAttribution: almaudoh commented 18 December 2016 at 10:04

There's a new patch over at #2642122: Overriding already overridden libraries-override requires knowledge of previous libraries-overrides that fixes this bug now and needs reviews and testing.

How do you think this should work?

I think the signature of a libraries-override should remain the same for specific library, irrespective of the thememail in which it is declared.

The reason why it is different for stable is that stable overrides almost all the libraries, while classy doesn't.

Comment #6

18 December 2016 at 10:04

Version:

8.2.x-dev

» 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #7

Chi CreditAttribution: Chi commented 28 February 2017 at 05:56

Parent issue:

» #2856499: Sub themes do not inherit "libraries-override"

it "inherits" the removing of toolbar.theme.css

Does it? I could not get it working on seven subtheme.

Comment #8

28 February 2017 at 05:56

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #9

28 February 2017 at 05:56

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #10

28 February 2017 at 05:56

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #11

almaudoh CreditAttribution: almaudoh commented 5 September 2019 at 23:46

Patch at https://www.drupal.org/project/drupal/issues/2642122#comment-13240019 that fixes this needs reviews.

Comment #12

5 September 2019 at 23:46

Version:

8.6.x-dev

» 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #13

5 September 2019 at 23:46

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #14

djsagar CreditAttribution: djsagar at OpenSense Labs commented 19 September 2020 at 20:06

Status:

Active

» Needs review

Hi @mortendk

Try this, this is the right example which you are looking for

Please let me know it's solve your problem or not.

 - seven/global-styling
libraries-override:
  system/base:
    css:
      component:
        /core/themes/stable/css/system/components/system-status-counter.css: css/components/system-status-counter.css
  core/drupal.vertical-tabs:
    css:
      component:
        misc/vertical-tabs.css: false
  core/jquery.ui:
    css:
      theme:
        assets/vendor/jquery.ui/themes/base/theme.css: false
  core/jquery.ui.dialog:
    css:
      component:
        assets/vendor/jquery.ui/themes/base/dialog.css: false
  classy/dialog:
    seven/seven.drupal.dialog
  classy/base:
    css:
      component:
        css/components/details.css: false

Comment #15

19 September 2020 at 20:06

Version:

8.9.x-dev

» 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #16

19 September 2020 at 20:06

Version:

9.2.x-dev

» 9.3.x-dev

Comment #17

19 September 2020 at 20:06

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #18

19 September 2020 at 20:06

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #19

smustgrave CreditAttribution: smustgrave at Mobomo commented 31 January 2023 at 20:23

Status:

Needs review

» Postponed (maintainer needs more info)

If #14 solves the issue.

Comment #20

31 January 2023 at 20:23

Version:

9.5.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.