Global php does not render available variable in drupal 8.2 versions

CommentFileSizeAuthor
#8 views_php-available_variables-2829204-8.patch1.09 KBrooby
#5 views_php-2829204.patch1.17 KBjoergM
#4 views_php_2829204.patch6.03 KBjoergM
Screenshot - 11212016 - 11:02:31 AM.png10.68 KBsajiniantony
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sajiniantony created an issue. See original summary.

PeteS’s picture

PeteS CreditAttribution: PeteS commented

This is coming from a substitution using SafeMarkup, which seems to have been deprecated in favor of FormattableMarkup. The placeholders (from FormattableMarkup::placeholderFormat) should be in the format of @variable, %variable or :variable depending on the level of sanitizing that is desired. I don't know what !variable was intended to do, or if it was a typo, but I suspect that the fix for this is to change instances of !link to :link or @link or whatever.

caspervoogt’s picture

caspervoogt CreditAttribution: caspervoogt at Plethora commented

PeteS, I think you're right, but I have tried a few things and can't get it to act any differently.

joergM’s picture

joergM CreditAttribution: joergM as a volunteer commented
Status: Active » Needs review
FileSize
views_php_2829204.patch6.03 KB

attached the patch for fixing the SafeMarkup::format issue.
Please review and comment.

joergM’s picture

joergM CreditAttribution: joergM as a volunteer commented
FileSize
views_php-2829204.patch1.17 KB

Update patchfile without git differences.

hswong3i’s picture

hswong3i CreditAttribution: hswong3i commented
Status: Needs review » Reviewed & tested by the community

Confirm #5 https://www.drupal.org/files/issues/views_php-2829204.patch works with drupal-8.2.6

rooby’s picture

rooby CreditAttribution: rooby commented

This issue has a fix for the deprecated functions, which will apply over the top of this patch: #2681065: Remove depreciated methods in code base.

rooby’s picture

rooby CreditAttribution: rooby commented
FileSize
views_php-available_variables-2829204-8.patch1.09 KB

This patch changes % replacements with @ replacements.
The reason being that the % replacements wrap the replacement in an em tag and that really isn't proper use of em tags in this case.

rooby’s picture

rooby CreditAttribution: rooby commented
DarkteK’s picture

DarkteK CreditAttribution: DarkteK commented

#8 worked great, thx!

boby_ui’s picture

boby_ui CreditAttribution: boby_ui commented

#8 confirmed working with 8.8.5, I understand all the patches should be implemented to the dev version?

boby_ui’s picture

boby_ui CreditAttribution: boby_ui commented