control + click does not open in new window/tab, it will just open in the same window.
It seems to be because the event.metaKey is being checked which according to the jQuery docs maps to the command key on macs and the windows key on windows.
https://api.jquery.com/event.metakey
This means that mac users will most likely have no problems as they use the command key + click to open in new window but windows and linux users use the control key + click.
It only appears to be an issue in jQuery 1.6+. The metaKey was mapped to the control key prior to that.
https://bugs.jquery.com/ticket/11328
https://bugs.jquery.com/ticket/10666
I've attached a patch that simply includes the event.ctrlKey in the check.
Comment | File | Size | Author |
---|---|---|---|
#4 | screenshot-1.png | 98.39 KB | ezraw |
coffee.ctrlKey.patch | 1.27 KB | kyoder | |
Comments
Comment #2
kyoder CreditAttribution: kyoder commentedComment #3
kyoder CreditAttribution: kyoder commentedComment #4
ezraw CreditAttribution: ezraw at Cadmium for EthosCE Learning Management System commentedTested and confirmed this works.
Users can right-click and open the links in new tab/window, and also alternatively use Ctrl+click to open in new tab. Screenshot attached.
Comment #5
ezraw CreditAttribution: ezraw at Cadmium for EthosCE Learning Management System commentedComment #6
delacosta456 CreditAttribution: delacosta456 commentedhi thanks
Worked for me
Comment #7
michaelmol CreditAttribution: michaelmol at Immer commented