Problem/Motivation

Users want to map custom language with locales in Lingotek. We should allow them to do that and edit them as needed.

Proposed resolution

Add locale to the forms.

Remaining tasks

Patch with tests.

User interface changes

Add locale to the language creation and edition forms.

API changes

Additions:
\Drupal\lingotek\LingotekInterface::getLocales()
\Drupal\lingotek\Remote\LingotekApiInterface::getLocales

Data model changes

None.

CommentFileSizeAuthor
#4 2828846-4.patch14.42 KBpenyaskito
#4 interdiff.txt4.27 KBpenyaskito
#3 interdiff.txt8.34 KBpenyaskito
#3 2828846-3.patch13.54 KBpenyaskito
#2 2828846-2.patch7.77 KBpenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Active » Needs review
FileSize
2828846-2.patch7.77 KB

Test with fix. There is no validation of locale.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
FileSize
2828846-3.patch13.54 KB
interdiff.txt8.34 KB

Added validation.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
FileSize
interdiff.txt4.27 KB
2828846-4.patch14.42 KB

Injected services into the language form.

  • penyaskito committed e49c109 on 8.x-1.x 
    Issue #2828846 by penyaskito: Add the option of editing the Lingotek...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs review » Fixed

Committed e49c109 and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented

Introduced #2844347: Error when downloading locales after adding a language