Problem/Motivation

JS.snakeCaseObject() breaks objects having camel case keys and string values, as obj[key] is undefined in that case.

Proposed resolution

Fix it.

Remaining tasks

  • Agree on a solution
  • Write a patch
  • Reviews

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 js-snake_case-2828768-2.patch474 bytesplach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach created an issue. See original summary.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach at Tag1 Consulting commented
Issue summary: View changes
Status: Active » Needs review
FileSize
js-snake_case-2828768-2.patch474 bytes

This may even be critical, as every object passed to an AJAX call will be passed to JS.snakeCaseObject().

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach at Tag1 Consulting commented
Assigned: plach » Unassigned
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach at Tag1 Consulting commented
Issue summary: View changes

  • markcarver committed 8ea6be1 on 7.x-2.x authored by plach 
    Issue #2828768 by plach: JS.snakeCaseObject() can break objects
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.