Please see the screenshots:

step1 - push button to open multiple upload pop-up
step 1

step2 - choose the files to be uploaded
step 2

step3 - choose next button and see uploaded file interfaces inside the pop-up window
Step 3

This is my configuration: plupload-7.x-1.7, multiform-7.x-1.3, Plupload library 1.5.8

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

charly71 created an issue. See original summary.

charly71’s picture

Anybody?

steinmb’s picture

Title: Pop-up window doesn't close itself and file uploaded are showed inside » plupload - Pop-up window doesn't close itself and file uploaded are showed inside
Version: 7.x-2.0-beta7 » 7.x-2.x-dev

Personally do not use plupload so no idea but try to stay with dev. and re-test if you can. Many changes goes into Media these days. A beta quickly gets old.

joseph.olstad’s picture

FileSize
10.47 KB

@charly71 I am very interested in this plupload functionality. This is something my clients will want.

Can you please try checking off this configuration option? I think it might help. ***EDIT*** Actually I doubt this suggestion will help, sorry ***EDIT***

See illustration below:

skip confirmation

joseph.olstad’s picture

You may also want to check off the option "Skip scheme selection" as well, these probably aren't needed when you're using the plupload plugin , however I'd like you to try it for me please.

***EDIT*** actually I doubt this suggestion will help.

joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

Issue summary: View changes
joseph.olstad’s picture

another related issue, this one is much older and not sure how much help it will be.

joseph.olstad’s picture

this one is somewhat related, not sure how much this related issue could help.

joseph.olstad’s picture

OK, I think I see a possible solution for this issue.

@charly71
apply the patch 1 (to the media module) in
#2212391: Add support for multiple file attachments on fields using Plupload + Media Multiselect

THEN, download the fe_paths module and apply this patch found in comment #22 , apply this to fe_paths:
#1877202: Support for File Fields

Try this, let me know if that helps.

joseph.olstad’s picture

Status: Active » Needs review

comment #10 needs review

charly71’s picture

FileSize
54.37 KB

Thank you Joseph for your feedback.
I just tried with beta10 version and the issue is still the same. I see the save button at the bottom of the pop-up, after the files, but this is not the old behavior: the pop-up does not close itself. I think this is still a bug and not a "work as designed". But maybe I'm wrong...

Regarding your suggestion (#10) to apply patches, it is too tricky for me.. I think I'll wait the next beta or stable version. Thank you anyway.

Bye

joseph.olstad’s picture

@charly71

to apply a patch, its quite easy

If you are on Linux, no problem

If you are on windows, download a copy of gitbash and install it.

use the command line provided by gitbash or Linux

cd /path/to/module
curl https://www.drupal.org/files/issues/media_bulk_upload-support-multiselect_2212391_1.patch > media_bulk_upload-support-multiselect_2212391_1.patch
#now you have the patch in the folder, to TEST the patch, do this:
patch -p1 --dry-run < media_bulk_upload-support-multiselect_2212391_1.patch
# if you are happy with the --dry-run test then apply it
patch -p1 < media_bulk_upload-support-multiselect_2212391_1.patch

now do the same for fe_path module, download that, grab the patch as mentioned.

ALTERNATIVELY you can clone git repos and use 'git apply' to apply the patches, but if you don't have the source control info you should use 'patch' as I mentioned.

joseph.olstad’s picture

to reverse a patch, run the same command, except with the -R option

so
patch -p1 -R < media_bulk_upload-support-multiselect_2212391_1.patch

-R option tells patch to reverse it.
you can also --dry-run a reverse
patch -p1 --dry-run -R < media_bulk_upload-support-multiselect_2212391_1.patch

interdruper’s picture

The same in my case. Moreover the files are not saved to the File field after closing the last window, so the issue is serious.

The issue is a regression caused by the commit: https://www.drupal.org/commitlog/commit/698/6605fe03b474f1c7b6d8be318c3bc70d4cec2082, from the issue #2818683: Bulk field editing after bulk uploading. So rolling back this commit fixes the new problem.

I haven't tried #10, but I doubt that requiring an additional module would be the proper approach.

About #2818683: Bulk field editing after bulk uploading, I understand the motivation, but I think that in many cases the additional edit form is not required and in these cases it is an additional and annoying step for the user, unless additional fields should be filled.

joseph.olstad’s picture

hi @interdruper , thanks very much for the analysis, lets deal with the regression.

brockfanning’s picture

@interdruper: Quick question - when you encounter the issue with the files not getting attached, how are you closing the popup window? Are you closing it with the save button at the bottom, or with the X in the upper right?

joseph.olstad’s picture

related issue is now fixed in 7.x-2.x dev, can you confirm if this issue can now also be closed as 'fixed' or 'closed duplicate' of 2818683?

#2818683: Bulk field editing after bulk uploading

charly71’s picture

@joseph

I tried 7.x-2.0-beta10+3-dev (2016-Dec-02) and my issue is still active: I see uploaded files in the popup and I must push save button to close it. Is there any trick to do automatic submit?

Thanks

brockfanning’s picture

@charly71 I think you may need to disable the new option at /admin/config/media/browser in the "Bulk Upload" section.

interdruper’s picture

Answering #20 and #17:

#20: new option 'Bulk upload edit ' in the latest dev works fine: if it is unchecked, the behaviour is the previous one, and the current issue does not arise.

#17: after closing the 2nd popup with the 'Save' button, a new pop-up appears. It can only be closed closing the window. After that, files are not attached to the field. Screenshots attached (2nd and 3rd popups)

brockfanning’s picture

Thanks @interdruper: You may not want to pursue, since disabling the option works for you. But it would be good to figure out why you're getting that 3rd popup. If you are open to further testing, re-enable that option and read on (no worries if not):

It appears that the media_bulk_upload_multiform_get_form_alter() function is not firing correctly for you. Just to make sure, can you do a full cache clear and try again? That may help to tell Drupal about that hook implementation.

charly71’s picture

@brockfanning

#20 works fine for me! Thanks a lot!

interdruper’s picture

About #22: well, mystery seems solved. I was used Multiform 7.x-1.1 and in effect, media_bulk_upload_multiform_get_form_alter() was not fired. Updating to latest Multiform 7.x-1.3 made the hook be called, and the files were properly inserted in the field (no 3rd form appears).

I guess that the recent patch to issue #1889652: Possibility to hook into multiple edit form (included in 1.3) is a requirement: a mention in the README (or a requirement in the .info file) would be nice.

joseph.olstad’s picture

@interduper Here's a patch to resolve the reported issue #24

Updating to latest Multiform 7.x-1.3 made the hook be called

queued for testing.

  • joseph.olstad committed dc27c2e on 7.x-2.x
    Issue #2828728 by joseph.olstad, charly71, interdruper: plupload - Pop-...
joseph.olstad’s picture

Status: Needs review » Fixed

change to media_bulk_upload.info file, dependency force multiform 1.3 or higher
fixed in dev 7.x-2.x branch of media

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.