tests failing with Function rules_test_custom_help() does not exist [#2828037]

As far as I can see tests are currently failing on the 7.x-2.x-dev branch, and also the 7.x-2.9 current release.

The error I'm seeing locally is:

Function rules_test_custom_help() does not exist in ReflectionFunction->__construct() (line 1811 of /var/www/html/sites/all/modules/contrib/rules/includes/rules.core.inc)

Trying to run the tests on simplytest.me I got the same error:

7.x-2.9:

An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /batch?render=overlay&id=2&op=do StatusText: Service unavailable (with message) ResponseText: ReflectionException: Function rules_test_custom_help() does not exist in ReflectionFunction->__construct() (line 1808 of /home/r1tj2/www/sites/default/modules/rules/includes/rules.core.inc).

7.x-2.x dev:

An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /batch?render=overlay&id=2&op=do StatusText: Service unavailable (with message) ResponseText: ReflectionException: Function rules_test_custom_help() does not exist in ReflectionFunction->__construct() (line 1811 of /home/d1tjr/www/sites/default/modules/rules/includes/rules.core.inc)

Tests on a patch to 7.x-2.x are currently failing, and the d.o test system suggests tests have not passed since January (around 10 months ago at present) e.g.

https://www.drupal.org/pift-ci-job/530658

...although the specific test failure there looks slightly different.

Comment	File	Size	Author
#3	rules-testbot-fix-2828037-3.patch	697 bytes	MegaChriz
#3	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 CI error

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

16 November 2016 at 11:15

mcdruid created an issue. See original summary.

Comment #2

MegaChriz CreditAttribution: MegaChriz as a volunteer commented 17 November 2016 at 08:38

It is running in the same problem I had with Feeds last week: the testbot doesn't checkout the variable module anymore, a dependency for i18n:

Before (branch test Jan 15, 2016):
DCI_AdditionalRepositories

git,git://git.drupal.org/project/rules.git,7.x-2.x,sites/all/modules/rules,1;
git,git://git.drupal.org/project/i18n.git,7.x-1.13,sites/all/modules/i18n,1;
git,git://git.drupal.org/project/variable.git,7.x-2.5,sites/all/modules/variable,1;
git,git://git.drupal.org/project/entity.git,7.x-1.6,sites/all/modules/entity,1;

After (test Nov 15, 2016):
DCI_AdditionalRepositories

git,git://git.drupal.org/project/rules.git,7.x-2.x,sites/all/modules/rules,1;
git,git://git.drupal.org/project/i18n.git,7.x-1.14,sites/all/modules/i18n,1;
git,git://git.drupal.org/project/entity.git,7.x-1.8,sites/all/modules/entity,1;

Comment #3

MegaChriz CreditAttribution: MegaChriz as a volunteer commented 17 November 2016 at 08:53

Status:

Active

» Needs review

File	Size
rules-testbot-fix-2828037-3.patch	697 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 CI error

This patch could fix the issue, but maybe we should file an issue against Project Dependency instead.

Comment #4

17 November 2016 at 08:56

Status:

Needs review

» Needs work

The last submitted patch, 3: rules-testbot-fix-2828037-3.patch, failed testing.

Comment #5

MegaChriz CreditAttribution: MegaChriz as a volunteer commented 17 November 2016 at 09:00

Status:

Needs work

» Needs review

Obviously, fails on the same error as the testbot doesn't check for additional dependencies in patches.

Comment #6

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid commented 17 November 2016 at 21:40

Thanks for looking into this MegaChriz.

The failure you've hit there:

08:54:48 Fatal error: Call to undefined function rule() in /var/www/html/sites/all/modules/rules/rules_i18n/rules_i18n.test on line 70
08:54:48 
08:54:48 Call Stack:
08:54:48     0.0014     898744   1. {main}() /var/www/html/scripts/run-tests.sh:0
08:54:48     0.0055    1788984   2. simpletest_script_run_one_test() /var/www/html/scripts/run-tests.sh:26
08:54:48     0.1805   26903720   3. DrupalTestCase->run() /var/www/html/scripts/run-tests.sh:386
08:54:48     5.5822   38072744   4. RulesI18nTestCase->testRulesConfigTranslation() /var/www/html/modules/simpletest/drupal_web_test_case.php:517

...look very similar to what we're hitting in #2406863: stampede protection should be flexible ("Cache rebuild lock hit" watchdog message).

However, away from the d.o CI system, it looks like tests are failing. For example try running the tests just for the main rules module at simplytest.me - when I did so with both 7.x-2.9 and 7.x-2.x-dev I hit:

ReflectionException: Function rules_test_custom_help() does not exist in ReflectionFunction->__construct()

...and I get the same thing running those tests locally.

That looks like a different thing to what you're describing with the problem (not) downloading the dependencies.

Comment #7

mcdruid

🇬🇧🇪🇺

CreditAttribution: mcdruid commented 11 February 2017 at 12:16

Tests are passing again in a couple of issues where I've submitted patches for rules-7.x-2.x so I don't know if this is a problem any more; perhaps not.