We should notify the user when he wants to use a plugin but has no tokens defined for it.
I will attach a patch that provides the three plugins with the validation.

CommentFileSizeAuthor
#9 menu_token-extra_validation_for_plugins-2827674-9.patch8.44 KBDevElCuy
#6 menu_token-extra_validation_for_plugins-2827674-6.patch8.43 KBalexverb
#4 2827674-4.patch4.75 KBalexverb
#3 2827674-3.patch4.57 KBalexverb
#2 2827674-2.patch4.65 KBalexverb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexverb created an issue. See original summary.

alexverb’s picture

alexverb CreditAttribution: alexverb as a volunteer commented
Status: Active » Needs review
FileSize
2827674-2.patch4.65 KB

Here you go.

alexverb’s picture

alexverb CreditAttribution: alexverb as a volunteer commented
FileSize
2827674-3.patch4.57 KB

Did small change to error message and reset file permissions right.

alexverb’s picture

alexverb CreditAttribution: alexverb as a volunteer commented
FileSize
2827674-4.patch4.75 KB

Sry guys, another fix for the error message (entity type label)

alexverb’s picture

alexverb CreditAttribution: alexverb as a volunteer commented
Status: Needs review » Needs work

Hmmm looking at the patch it may be a good idea to refractor and remove duplicated code to helper functions.

alexverb’s picture

alexverb CreditAttribution: alexverb as a volunteer commented
Status: Needs work » Needs review
FileSize
menu_token-extra_validation_for_plugins-2827674-6.patch8.43 KB

I have restructured the classes for this added feature. Cleaner this way.

alexverb’s picture

alexverb CreditAttribution: alexverb as a volunteer commented

Hiding obsolete patches.

DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy at Dilygent commented
Status: Needs review » Active
Issue tags: +performance issue

This is a big one @alexverb, much thanks!

DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy at Dilygent commented
FileSize
menu_token-extra_validation_for_plugins-2827674-9.patch8.44 KB

Up to date patch (against current source code).

  • develCuy committed 937c519 on 7.x-1.x 
    Issue #2827674 by alexverb, develCuy: Add extra validation to prevent...
DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy at Dilygent commented
Status: Active » Fixed

Good job @alexverb!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.