Attached patch fixes coding standard issues.

CommentFileSizeAuthor
#9 voting_api-fix_coding_standards-2827038-9.patch135.83 KBAhmadZain
#5 fix_coding_standards-2827038-5.patch21.81 KBManav
#2 fix_coding_standards-2827038-2.patch16.58 KBManav
fix_coding_standard_votingapi_0.patch1.2 KBSubhransu.addweb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

denisha.kalariya created an issue. See original summary.

Manav’s picture

Manav CreditAttribution: Manav as a volunteer and at QED42 commented
Assigned: Unassigned » Manav
FileSize
fix_coding_standards-2827038-2.patch16.58 KB

Hi @denisha.kalariya,

Your patch is working fine but there are lots of coding standard issues in these file. I have fix all these issues with my latest patch.

Thanks
Manav

Manav’s picture

Manav CreditAttribution: Manav as a volunteer and at QED42 commented
Assigned: Manav » Unassigned

Status: Needs review » Needs work

The last submitted patch, 2: fix_coding_standards-2827038-2.patch, failed testing.

Manav’s picture

Manav CreditAttribution: Manav as a volunteer and at QED42 commented
Assigned: Unassigned » Manav
FileSize
fix_coding_standards-2827038-5.patch21.81 KB
Manav’s picture

Manav CreditAttribution: Manav as a volunteer and at QED42 commented
Assigned: Manav » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: fix_coding_standards-2827038-5.patch, failed testing.

Manav’s picture

Manav CreditAttribution: Manav as a volunteer and at QED42 commented

I have checked this CI error this is due to Permission on PHP "Warning: fopen(/var/lib/drupalci/web/jenkins-default-282086/sites/all/modules/votingapi/fix_coding_standards-2827038-2.patch): failed to open stream: Permission denied in /opt/drupalci_testbot/vendor/guzzle/guzzle/src/Guzzle/Http/Message/Request.php on line 438"

Check this link CI error console for more details about this CI error. Patch is fine but the error is due to permission. Even i have check the simpletest on this file locally and its also working fine.

Thanks
Manav

AhmadZain’s picture

AhmadZain CreditAttribution: AhmadZain as a volunteer and commented
FileSize
voting_api-fix_coding_standards-2827038-9.patch135.83 KB

Hi Guys,

I tried to modify the code to fix coding standards for #2827038: Fix coding standards.

So please check.

Best
Zain

Manav’s picture

Manav CreditAttribution: Manav as a volunteer and at QED42 commented
Assigned: Unassigned » Manav

After applied #9 patch its failed.

Manav’s picture

Manav CreditAttribution: Manav as a volunteer and at QED42 commented
Assigned: Manav » Unassigned
AhmadZain’s picture

AhmadZain CreditAttribution: AhmadZain commented

Can you mention the fail reasons ?? I can see the issue with the automation scripts or what is the exact rason

Thanks

TR’s picture

TR CreditAttribution: TR commented
Status: Needs work » Closed (won't fix)
  1. This patch has never applied.
  2. No one has worked on it in 3 years.
  3. Patch make literally hundreds of WRONG changes. For example:
    -    $nid = variable_get('votingapi_nid1', NULL);
+    $nid = variable_get('votingapi_nid1' , NULL);

    Adding a space before the comma is just wrong - the original version is the correct version.

You are CREATING hundreds of coding standards problems with this patch.

This patch can't be salvaged - it's more work to fix the patch than it would be to start from scratch. For that reason, I'm closing this as 'won't fix'. If you would like to help out with coding standards please open a new issue and please confine your patches to 1 and only 1 type of coding standards problem - trying to fix everything with one patch makes that patch unreviewable and fragile because it will conflict with almost every other patch currently in the issue queue.